Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace express with fastify #57

Merged
merged 3 commits into from
Aug 15, 2021
Merged

Replace express with fastify #57

merged 3 commits into from
Aug 15, 2021

Conversation

Drevoed
Copy link
Contributor

@Drevoed Drevoed commented Aug 13, 2021

Branch name

  • Your branch should be prefixed with feature/ or fix/ or chore/ or refactor/ or tests/
  • Add issue identifier
  • Add 3-5 words of description separated with -

Example:

feature/BOX-12-add-login-form
fix/BOX-8-loading-panel-on-first-load
chore/BOX-22-add-release-drafter

PullRequest

  • This PullRequest implements new feature, fix bug, or some other changes
  • If PR is not ready to review mark it as Draft
  • All commits in this PR should be created by yarn commit by conventional-commits
  • Title of the PullRequest should have issue(s) identifier(s) ("BOX-123 Example title of PR")

@Drevoed Drevoed requested review from sergeysova and azinit August 13, 2021 15:08
@Drevoed Drevoed self-assigned this Aug 13, 2021
dmi-ch
dmi-ch previously approved these changes Aug 14, 2021
View reviewed changes
Copy link
Contributor

@dmi-ch dmi-ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

src/app/server.tsx
}>();

const requestHandled = serverStarted.map(({ req }) => req);

const cookiesReceived = requestHandled.filterMap((r) => r.headers.cookie);

const routesMatched = requestHandled.map((request) => ({
routes: matchRoutes(ROUTES, request.path).filter(lookupStartEvent),
routes: matchRoutes(ROUTES, request.url).filter(lookupStartEvent),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

кажется тут можно не менять было, у них alias path

@Drevoed Drevoed requested a review from dmi-ch August 15, 2021 10:51
@sergeysova sergeysova changed the title Feature/replace express with fastify Replace express with fastify Aug 15, 2021
@sergeysova sergeysova enabled auto-merge (squash) August 15, 2021 10:51
@sergeysova sergeysova merged commit 729c472 into master Aug 15, 2021
@sergeysova sergeysova deleted the feature/replace-express-with-fastify branch August 15, 2021 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergeysova sergeysova sergeysova approved these changes

@dmi-ch dmi-ch dmi-ch approved these changes

@azinit azinit Awaiting requested review from azinit

Assignees

@Drevoed Drevoed

Labels
Infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Drevoed @dmi-ch @sergeysova