BOX-241: Rename font, change method to include it #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Kater-auf-Dach
commented
Oct 16, 2021
Kater-auf-Dach
commented
- Replace "Hover" with "Hoves" in font name
- Replace relative path to fonts with imports
azinit
approved these changes
Oct 16, 2021
Comment on lines
+1
to
+18
| import BlackItalicWoff2 from '@box/shared/assets/fonts/TT_Hoves_Black_Italic.woff2'; | ||
| import BlackWoff2 from '@box/shared/assets/fonts/TT_Hoves_Black.woff2'; | ||
| import BoldItalicWoff2 from '@box/shared/assets/fonts/TT_Hoves_Bold_Italic.woff2'; | ||
| import BoldWoff2 from '@box/shared/assets/fonts/TT_Hoves_Bold.woff2'; | ||
| import DemiBoldItalicWoff2 from '@box/shared/assets/fonts/TT_Hoves_DemiBold_Italic.woff2'; | ||
| import DemiBoldWoff2 from '@box/shared/assets/fonts/TT_Hoves_DemiBold.woff2'; | ||
| import ExtraBoldItalicWoff2 from '@box/shared/assets/fonts/TT_Hoves_ExtraBold_Italic.woff2'; | ||
| import ExtraBoldWoff2 from '@box/shared/assets/fonts/TT_Hoves_ExtraBold.woff2'; | ||
| import ExtraLightItalicWoff2 from '@box/shared/assets/fonts/TT_Hoves_ExtraLight_Italic.woff2'; | ||
| import ExtraLightWoff2 from '@box/shared/assets/fonts/TT_Hoves_ExtraLight.woff2'; | ||
| import ItalicWoff2 from '@box/shared/assets/fonts/TT_Hoves_Italic.woff2'; | ||
| import LightItalicWoff2 from '@box/shared/assets/fonts/TT_Hoves_Light_Italic.woff2'; | ||
| import LightWoff2 from '@box/shared/assets/fonts/TT_Hoves_Light.woff2'; | ||
| import MediumItalicWoff2 from '@box/shared/assets/fonts/TT_Hoves_Medium_Italic.woff2'; | ||
| import MediumWoff2 from '@box/shared/assets/fonts/TT_Hoves_Medium.woff2'; | ||
| import RegularWoff2 from '@box/shared/assets/fonts/TT_Hoves_Regular.woff2'; | ||
| import ThinItalicWoff2 from '@box/shared/assets/fonts/TT_Hoves_Thin_Italic.woff2'; | ||
| import ThinWoff2 from '@box/shared/assets/fonts/TT_Hoves_Thin.woff2'; |
There was a problem hiding this comment.
@sergeysova @dmi-ch А в стайледах точно так делается?
There was a problem hiding this comment.
Ну по относительному пути не подтянулись, наверно, нужно сборку посмотреть. Собственно, в этом проблема и была. Так-то обычно в public/assets клали, но здесь ассетсы в сорцах...
There was a problem hiding this comment.
Увы, по другому никак, пока что
Пусть так, потом разберемся и оптимизируем. Может на CDN закинем
sergeysova
approved these changes
Oct 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.