Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change notemap to concert pitch and add --transpose CLI flag #27

Merged
merged 2 commits into from
Jan 7, 2024

Conversation

petermoz
Copy link
Collaborator

@petermoz petermoz commented Jan 7, 2024

This implements half of #19, also discussed here: cardonabits/haxo-hw#60

This PR changes the notemap to be in concert pitch: after this change you can think of the notemap as translating between "keys pressed" and "note written on the music". This is constant across all saxophones - i.e. the lowest note in the notemap will represent "Low Bb" (ignoring Bari Low A).

Since the notemap will be concert pitch, we also introduce a CLI flag to change the transposition (i.e. the mapping from "written note" to "how the note sounds"), which is different for all saxophones. This --transpose flag can be set on the command line or in the haxo.service settings and defaults to -14 to match the current haxophone default behavior (a tenor saxophone).

Here's the --transpose setting you should use to achieve different instruments

instrument --transpose
soprano -2
alto -9
tenor -14
bari -21

@petermoz
Copy link
Collaborator Author

petermoz commented Jan 7, 2024

@gerdb - I saw in #18 that you wrote a notemap viewer. In this PR (and related discussions) we've proposed to redefine the notemap to be in concert pitch. I assume that'll necessitate changes to your viewer to match.

I've found the viewer very handy by the way, I keep forgetting how to play everything above high D :)

@jcard0na jcard0na merged commit 5fd1276 into cardonabits:main Jan 7, 2024
@petermoz petermoz deleted the transpose branch January 7, 2024 00:23
@jcard0na
Copy link
Collaborator

jcard0na commented Jan 7, 2024

In this PR (and related discussions) we've proposed to redefine the notemap to be in concert pitch. I assume that'll necessitate changes to your viewer to match.

Well spotted. My fingering viewer also broke with this change (https://haxo-notemap.nn.r.appspot.com/). I just fixed it.

(But I prefer @gerdb's viewer!)

@gerdb
Copy link
Contributor

gerdb commented Jan 7, 2024

Updated the viewer to concert pitch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants