Change notemap to concert pitch and add --transpose
CLI flag
#27
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements half of #19, also discussed here: cardonabits/haxo-hw#60
This PR changes the notemap to be in concert pitch: after this change you can think of the notemap as translating between "keys pressed" and "note written on the music". This is constant across all saxophones - i.e. the lowest note in the notemap will represent "Low Bb" (ignoring Bari Low A).
Since the notemap will be concert pitch, we also introduce a CLI flag to change the transposition (i.e. the mapping from "written note" to "how the note sounds"), which is different for all saxophones. This
--transpose
flag can be set on the command line or in thehaxo.service
settings and defaults to -14 to match the current haxophone default behavior (a tenor saxophone).Here's the
--transpose
setting you should use to achieve different instruments--transpose