Adding support for Spies in Code Generation #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoSignoretto
force-pushed
the
ksp-spies
branch
2 times, most recently
from
cc6c711
to
7f1987a
Compare
MarcoSignoretto
changed the base branch from
master
to
cover-codegen-from-regression
This patch allows the new ksp based code generator to generate Spies in addition to mocks
MarcoSignoretto
force-pushed
the
ksp-spies
branch
from
7f1987a
to
c4a0cbe
Compare
MarcoSignoretto
changed the base branch from
cover-codegen-from-regression
to
master
MarcoSignoretto
changed the title
MarcoSignoretto
commented
Oct 3, 2022
Comment on lines
+29
to
+35
| interface CodeBlockFactory { | ||
| fun resolveSupertype(): String | ||
| fun decorateConstructor(classToMock: KSType, classBuilder: TypeSpec.Builder) | ||
| fun decorateFunctionBody(classToMock: KSClassDeclaration, function: KSFunctionDeclaration, isUnit: Boolean, functionBuilder: FunSpec.Builder) | ||
| fun decoratePropertyGetter(classToMock: KSClassDeclaration, property: KSPropertyDeclaration, propertyBuilder: PropertySpec.Builder, typeResolver: Map<KSTypeParameter, KSTypeArgument>) | ||
| fun decoratePropertySetter(classToMock: KSClassDeclaration, property: KSPropertyDeclaration, propertyBuilder: PropertySpec.Builder, typeResolver: Map<KSTypeParameter, KSTypeArgument>) | ||
| } |
There was a problem hiding this comment.
this si where codegen is different in Spies respect to mocks
MarcoSignoretto
commented
Oct 3, 2022
| import com.squareup.kotlinpoet.ksp.toKModifier | ||
| import com.squareup.kotlinpoet.ksp.toTypeName | ||
|
|
||
| abstract class Generator constructor( |
There was a problem hiding this comment.
just rename of MockGenerator, non common logic has been extracted to MockGenerator and SpyGenerator
MarcoSignoretto
commented
Oct 3, 2022
| ) | ||
| } | ||
|
|
||
| override fun decorateFunctionBody( |
There was a problem hiding this comment.
function body is different between mocks and spies, this is the spy impl for the code gen of that block
MarcoSignoretto
commented
Oct 3, 2022
Comment on lines
+26
to
+28
| // @Spy | ||
| // lateinit var pippoMock: PippoSample | ||
| // FIXME suspend function is not working |
There was a problem hiding this comment.
this will be supported in future PRs
carlonzo
approved these changes
Oct 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch allows the new ksp based code generator to generate Spies in addition to mocks
TODO: