Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use rust-lld in CI #1253

Merged
merged 1 commit into from
Aug 8, 2023
Merged

Use rust-lld in CI #1253

merged 1 commit into from
Aug 8, 2023

Conversation

NobodyXu
Copy link
Member

@NobodyXu NobodyXu commented Aug 6, 2023

Which guarantees:

  • faster linking on all targets when cargo-zigbuild is not used
  • allow cross-lang-lto to be enabled

@NobodyXu NobodyXu mentioned this pull request Aug 6, 2023
Closed
@NobodyXu NobodyXu force-pushed the use-lld-in-ci branch 2 times, most recently from 89db67e to 23104af Compare August 6, 2023 13:52
@NobodyXu
Use rust-lld in CI
68a2a47 
Which guarantees:
 - faster linking on all targets when `cargo-zigbuild` is not used
 - allow cross-lang-lto to be enabled

Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu NobodyXu requested a review from passcod August 7, 2023 00:25
@NobodyXu
Copy link
Member Author

NobodyXu commented Aug 7, 2023

@passcod One question I has is whether CARGO_TARGET_<triple>_LINKER has to be all in upper case? Could the <triple> be specified in lower-case?

BTW, our CARGO_REGISTRY_{registry_name}_INDEX environment variable also doesn't convert to upper case before fetching it.

@NobodyXu
Copy link
Member Author

NobodyXu commented Aug 7, 2023

Based on this comment rust-cross/cargo-zigbuild#158 (comment) I think it's safe to say that cargo support both lower case and upper case.

@NobodyXu NobodyXu added this pull request to the merge queue Aug 8, 2023
Merged via the queue into main with commit 1e4e0d1 Aug 8, 2023
@NobodyXu NobodyXu deleted the use-lld-in-ci branch August 8, 2023 01:34
@NobodyXu NobodyXu mentioned this pull request Aug 8, 2023
Closed
NobodyXu added a commit that referenced this pull request Aug 8, 2023
@NobodyXu
Revert "Use rust-lld in CI (#1253)"
6c18aa6 
This reverts commit 1e4e0d1.
@NobodyXu NobodyXu mentioned this pull request Aug 8, 2023
Merged
NobodyXu added a commit that referenced this pull request Aug 8, 2023
@NobodyXu
Revert "Use rust-lld in CI (#1253)"
3c40473 
This reverts commit 1e4e0d1.

Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu NobodyXu mentioned this pull request Aug 8, 2023
Merged
github-merge-queue bot pushed a commit that referenced this pull request Aug 8, 2023
@NobodyXu
Revert "Use rust-lld in CI" (#1257)
2fbcf18 
Revert "Use `rust-lld` in CI (#1253)"

This reverts commit 1e4e0d1.

Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@passcod passcod passcod approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NobodyXu @passcod