Sign our releases #1347
Merged
Sign our releases #1347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
NobodyXu
requested changes
Sep 17, 2023
passcod
force-pushed
the
signing-releases
branch
from
6e98104
to
39dbdf7
Compare
NobodyXu
requested changes
Sep 23, 2023
NobodyXu
approved these changes
Sep 23, 2023
|
It would be great if we can add testing for our release pipeline, though it won't be easy to add so I won't make it a blocker for this PR |
|
yehmmmm I think we'll have to test this one live. I've run the scripts locally simulating the environment as best I can, though, so, not going in totally blind |
This was referenced Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses an ephemeral key.
It writes the
[signing]section to the Cargo.toml just before publish, so the Cargo.toml in the source remains without, which makes--gitinstalls work (just without verifying signatures).It uses rsign2 so we can install it via binstall (dogfooding!).