Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rm NOVERSION_FILENAMES "{ name }{ archive-suffix }" #795

Merged
merged 2 commits into from
Feb 13, 2023

Conversation

NobodyXu
Copy link
Member

which does not contain target, hence it might report the binary being available for any target we specified.

Signed-off-by: Jiahao XU Jiahao_XU@outlook.com

which does not contain `target`, hence it might report the binary being
available for any target we specified.

Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu NobodyXu requested a review from passcod February 12, 2023 12:17
@passcod
Copy link
Member

passcod commented Feb 12, 2023

I agree semantically but let's make sure to very explicitly call this out on release, as that could be quite a surprising breaking change.

@passcod passcod added the PR: improvement PR that improves existing features or code label Feb 12, 2023
@NobodyXu
Copy link
Member Author

I agree semantically but let's make sure to very explicitly call this out on release, as that could be quite a surprising breaking change.

Got it.

@NobodyXu NobodyXu merged commit 04113e9 into main Feb 13, 2023
@NobodyXu NobodyXu deleted the fix/auto-discovery branch February 13, 2023 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: improvement PR that improves existing features or code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants