Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix x86_64 fallback for aarch64 MacOS #875

Merged
merged 1 commit into from
Mar 10, 2023

Conversation

NobodyXu
Copy link
Member

@NobodyXu NobodyXu commented Mar 10, 2023

Fixed #857

Run arch -arch x86_64 /usr/bin/true to check whether rosetta2 is enabled and working.

Signed-off-by: Jiahao XU Jiahao_XU@outlook.com

Fixed #857

Run `arch -arch x86_64 /usr/bin/true` to check whether rosetta2 is
enabled and working.

Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu NobodyXu requested a review from passcod March 10, 2023 04:33
@NobodyXu
Copy link
Member Author

@0xazure Can you please test this PR on your mac and see if it works for you?

@NobodyXu NobodyXu merged commit a22cb3a into main Mar 10, 2023
@NobodyXu NobodyXu deleted the fix/x86_64-fallback-for-aarch64-macos branch March 10, 2023 11:09
@0xazure
Copy link

0xazure commented Mar 11, 2023

Hi @NobodyXu thanks for the ping!

Tested with a22cb3a where this was merged into main; confirmed binstall no longer tries to download x86_64-apple-darwin artifacts if Rosetta 2 is not available and instead falls back to building from source as expected.

Thanks so much, looking forward to the next release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

binstall installs x86_64 binaries on macOS aarch64 without Rosetta 2 enabled
3 participants