milo/support aarch64 unknown gnu

[Milo123459]

This allows cargo-quickbuild to build for aarch64-unknown-linux-gnu.

[NobodyXu]

For the linter error:

[NobodyXu]

Could you be hitting ziglang/zig#4911 ?

[Milo123459]

I think so.

[Milo123459]

getting a new error this time. cc @NobodyXu - any ideas?

[Milo123459]

right - now im trying to make it use the NDK version of ld. currently, when i move ld to /usr/bin, the shell doesn't pick up that there is something in that directory called ld and now errors out because it cannot find it. it turns out that the sudo mv isn't actually moving the file, i think

[Milo123459]

cc @alsuren - any ideas

[alsuren]

Please give your squashed commit a better name, and consider my suggestions (it may be that you already tried them)

I would quite like to try one of these binaries in docker on my m1 mac. Let's ship it and get it building stuff :D

[Milo123459]

i can't merge it because there are some review changes that haven't been addressed (even though they have). @alsuren could you merge it for me? thanks

[alsuren]

The "request changes" review is blocking the merge. I tend to avoid using that button because it feels impolite (I always tend to leave feedback as "comment"). I hadn't realised that it also blocks merging in the presence of other approvers :-(.

If you want to smoke test it before we merge to main, push it to the actions branch and it will kick off a one-off cronjob using your code.

[Milo123459]

alright, i'll push it! fingers crossed

[Milo123459]

seems to have worked! should i delete the actions branch?

[Milo123459]

nvm, it's failing because it's using a weird version of the branch causing it to not have access to a file. in practice, this won't happen if this is merged and the cron just runs.

ps @alsuren - can you not override the requested changes thing and merge it?

[alsuren]

ps @alsuren - can you not override the requested changes thing and merge it?

Oh hey: there is a "dismiss review" item in the menu.

I still think that https://github.com/cargo-bins/cargo-quickinstall/actions/runs/4033938309/jobs/6934774496#step:4:89 (

error: linker `/home/runner/work/cargo-quickinstall/cargo-quickinstall/zig-aarch64.sh` not found

) is a problem that we're also going to see on main. Let me have a quick dig about.

outdated

[alsuren]

I just tested it out in arm docker, and cargo-quickinstall cargo-quickinstall now works (once I installed curl). Good work, and thanks for sticking with it.

Glancing at https://github.com/cargo-bins/cargo-quickinstall/pull/123/commits still doesn't tell me anything about what this PR is about, so it's likely to cause problems for anyone doing archaeology later (although they will have enough problems unpicking my commits, so they might not notice yours).

Otherwise, you have an approval and I think you have merge access, so ship it.

Now it's well past my bedtime. I might do some more quickinstall hacking tomorrow though.

[Milo123459]

Woo! I'll squash my commits again. Just testing the actions branch then I'll give it a merge!

[Milo123459]

Seeing some errors @alsuren 😬 https://github.com/cargo-bins/cargo-quickinstall/actions/runs/4034450545/jobs/6935671373#step:5:101

PS: I ran cargo quickinstall cargo-binstall on my Raspberry Pi, that has the aarch64-unknown-linux-gnu target, but a workflow run was never created for it.

[NobodyXu]

This error is caused by my PR #140, will fix it