Fixed issue where fk insert instruction was added even though it had …

…previously been specified
carl-berg · Dec 8, 2020 · fb384f1 · fb384f1
1 parent d7f8487
commit fb384f1
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 6 deletions.
diff --git a/DataDude.Tests/Inserts/AutoInsertFKTableTestscs.cs b/DataDude.Tests/Inserts/AutoInsertFKTableTestscs.cs
@@ -29,7 +29,7 @@ public async Task Chain()
         }
 
         [Fact]
-        public async Task Chain_Sparsely_Specified()
+        public async Task Chain_Sparsely_Specified_Scenario_1()
         {
             var schema = new TestSchema();
             var a = schema.AddTable("A");
@@ -47,5 +47,25 @@ public async Task Chain_Sparsely_Specified()
                 .Select(x => x.TableName)
                 .ShouldBe(new[] { "dbo.A", "B", "dbo.C", "D" });
         }
+
+        [Fact]
+        public async Task Chain_Sparsely_Specified_Scenario_2()
+        {
+            var schema = new TestSchema();
+            var a = schema.AddTable("A");
+            var b = schema.AddTable("B").AddFk(a);
+            var c = schema.AddTable("C").AddFk(b);
+            var d = schema.AddTable("D").AddFk(c);
+
+            var context = new DataDudeContext() { Schema = schema };
+
+            context.Instructions.Add(new InsertInstruction("A"));
+            context.Instructions.Add(new InsertInstruction("D"));
+            await new AddMissingInsertInstructionsPreProcessor().PreProcess(context);
+            context.Instructions
+                .OfType<InsertInstruction>()
+                .Select(x => x.TableName)
+                .ShouldBe(new[] { "A", "dbo.B", "dbo.C", "D" });
+        }
     }
 }
diff --git a/DataDude/DataDude.csproj b/DataDude/DataDude.csproj
@@ -4,7 +4,7 @@
     <TargetFramework>netstandard2.0</TargetFramework>
     <LangVersion>9.0</LangVersion>
     <Nullable>enable</Nullable>
-    <Version>0.4.0-beta.1</Version>
+    <Version>0.4.0-beta.2</Version>
     <GenerateDocumentationFile>true</GenerateDocumentationFile>
     <IncludeSymbols>true</IncludeSymbols>
     <SymbolPackageFormat>snupkg</SymbolPackageFormat>

diff --git a/...Dude/Instructions/Insert/AutomaticForeignKeys/AddMissingInsertInstructionsPreProcessor.cs b/...Dude/Instructions/Insert/AutomaticForeignKeys/AddMissingInsertInstructionsPreProcessor.cs
@@ -23,10 +23,7 @@ public Task PreProcess(DataDudeContext context)
                         .Where(t => !toInsert.Values.Any(x => x.Contains(t)))
                         .ToList();
 
-                    if (dependencies.Any())
-                    {
-                        toInsert.Add(instruction, new InsertInformation(table, dependencies));
-                    }
+                    toInsert.Add(instruction, new InsertInformation(table, dependencies));
                 }
             }