-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement datatyping.printer with subclassing #7
Comments
Hey! I just started to do some work on this. One thing I noticed is that |
This PR has the change: #9 |
This is super nice! Does it make sense for I think I disabled the test, because it makes a http request. Maybe once #4 is done, we can have tests for this. |
I don't think _new_safe_repr should be in the subclass - I've tried to put the minimum number of overrides in there, and the current way mirrors how pprint._safe_repr works. |
Awesome work! /merged/ |
I was super stupid, when I implemented
datatyping.printer.py
. It should be implemented with subclassing instead of monkey patching (with context managers). This would also make it thread-safe.Relevant: #2.
The text was updated successfully, but these errors were encountered: