-
-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Print Git command if it failed #681
Print Git command if it failed #681
Conversation
Hey! Thanks for opening a PR Is there any difference between copying the command from the output of the error and using the arrow up key to replicate the same comand without having to manually copy&pasting it? IMHO using arrow key should be much faster, so I don't really see the point of this 🤔 |
When I use gitmoji -c, I do not provide any other parameters and enter gitmoji and message in the cli. If I use arrow up key, I can not find again the parameters I filled previously. |
I think a screenshot/demo about this would be really helpful 😊 |
output.mp4 |
Thanks for sharing! But this is the current behaviour right? I was asking for a demo of your change to see what is printed, thank you 🙏🏼 |
Oh sorry, I was just wondering if I was using the cli well. With the new version the command would be printed if it fail simplescreenrecorder-2021-09-16_18.39.48.mp4 |
Yes sure, but often I think about the gitmoji, title and message after having typed |
Codecov Report
@@ Coverage Diff @@
## master #681 +/- ##
=======================================
Coverage 92.13% 92.13%
=======================================
Files 26 26
Lines 229 229
Branches 49 49
=======================================
Hits 211 211
Misses 17 17
Partials 1 1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's merge it 😊
Description
If commit fails to execute, cli prints command so it can be copy / paste without executing again gitmoji-cli.
Updated the tests too.
Issue: #680
Tests