Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Choice iterator breakage against Django pre-5.0 #1605

Closed
carltongibson opened this issue Aug 31, 2023 · 1 comment · Fixed by #1607
Closed

Choice iterator breakage against Django pre-5.0 #1605

carltongibson opened this issue Aug 31, 2023 · 1 comment · Fixed by #1607

Comments

@carltongibson
Copy link
Owner

Refs django/django#16943
Refs wagtail/wagtail#10846

  File "/Users/carlton/Projects/Django/django-filter/.tox/py311-latest/lib/python3.11/site-packages/django/forms/fields.py", line 874, in __init__
    self.choices = choices
    ^^^^^^^^^^^^
  File "/Users/carlton/Projects/Django/django-filter/django_filters/fields.py", line 264, in _set_choices
    super()._set_choices(value)
    ^^^^^^^^^^^^^^^^^^^^
AttributeError: 'super' object has no attribute '_set_choices'
carltongibson added a commit to deronnax/django-filter that referenced this issue Aug 31, 2023
@carltongibson
Skip Django Latest failures.
2c28576 
Refs carltongibson#1605
This was referenced Aug 31, 2023
Closed
Merged
carltongibson added a commit to deronnax/django-filter that referenced this issue Aug 31, 2023
@carltongibson
Skipped Django Pre-5.0 failures.
b3f2577 
Refs carltongibson#1605
@carltongibson carltongibson mentioned this issue Aug 31, 2023
Merged
carltongibson added a commit that referenced this issue Aug 31, 2023
@carltongibson
Skipped Django Pre-5.0 failures.
e5fc05d 
Refs #1605
@carltongibson carltongibson pinned this issue Aug 31, 2023
@carltongibson
Copy link
Owner Author

The initial ChoiceIterator changes are here:

@carltongibson carltongibson linked a pull request Sep 1, 2023 that will close this issue
Fixes for Django 5.0. #1606
Closed
@ngnpope ngnpope mentioned this issue Sep 1, 2023
Merged
@carltongibson carltongibson linked a pull request Sep 4, 2023 that will close this issue
Added support for Django 5.0. #1607
Merged
@carltongibson carltongibson unpinned this issue Sep 17, 2023
last-partizan pushed a commit to last-partizan/django-filter that referenced this issue Sep 12, 2024
@carltongibson @last-partizan
Skipped Django Pre-5.0 failures.
cff5b9b 
Refs carltongibson#1605
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@carltongibson