-
Notifications
You must be signed in to change notification settings - Fork 771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SuffixedMultiWidget #681
Add SuffixedMultiWidget #681
Conversation
50f475b
to
b134d36
Compare
Codecov Report
@@ Coverage Diff @@
## develop #681 +/- ##
===========================================
- Coverage 98.11% 97.99% -0.13%
===========================================
Files 15 15
Lines 1117 1148 +31
===========================================
+ Hits 1096 1125 +29
- Misses 21 23 +2
Continue to review full report at Codecov.
|
Looks good. I had thought that the new widget probably could not be the default, simply because it's contrary to the standard API... |
Makes sense. Eventually (next major version?) should the default change to using |
Not sure at this point. 🙂 |
cb47d16
to
cdbeab7
Compare
Okay - the breaking changes have been split off into a separate commit, and I'll submit a new PR for consideration once this has been reviewed/accepted. |
I'm coming round to a 2.0, dropping Python 2 support. |
f25a7a4
to
cdbeab7
Compare
Pushed the breaking commit to |
799ded1
to
8c15b6a
Compare
rebased |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
* Add SuffixedMultiWidget * Add SuffixedMultiWidget support for django < 1.11 * Add SuffixedMultiWidget tests * Add SuffixedMultiWidget docs
Resolves #425. Not sure if this would be considered for a major/minor release given the API changes.
Changes:
SuffixedMultiWidget
RangeWidget
to usemin
/max
suffixesDateRangeWidget
that usesafter
/before suffixes (could remove and just use
RangeWidget`)LookupTypeWidget
to just the field name and alookup
suffix. So,?price=15&price_lookup=lt
TODO: