Deprecations for 2.0

[rpkilby]

• Rename Filter.name => Filter.field_name
• Deprecate Meta.together
• Deprecation note for FILTERS_STRICTNESS, Meta.strict, FilterSet.strict

[carltongibson]

Yep. I think that'll do.

[rpkilby]

Ach. Why do you forsake my python 2???

[rpkilby]

I am perplexed - this does not fail locally for me.

[carltongibson]

Give me a sec. I will give it a run.

[carltongibson]

Right, I'm perplexed too.

Travis has two failures. (One for each test).

I'm getting a failure just for the second.

................................................F..........................................................s..x...ss..x..x..........................................................................................................................................................................................................................s.........................sss..................................................................................
======================================================================
FAIL: test_filter_strictness (tests.test_deprecations.DeprecatedSettingsTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/carlton/Documents/Django-Stack/django-filter/tests/test_deprecations.py", line 37, in test_filter_strictness
    self.assertEqual(len(w), 1)
AssertionError: 0 != 1

----------------------------------------------------------------------
Ran 451 tests in 1.274s

FAILED (failures=1, skipped=7, expected failures=3)

Given that it's exactly the same as the first, that doesn't make much sense to me.

[rpkilby]

I'll have to come back to this tomorrow - I can't figure out what's going on :/

[codecov-io]

Codecov Report

Merging #792 into develop will increase coverage by 0.1%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           develop     #792     +/-   ##
==========================================
+ Coverage    97.45%   97.56%   +0.1%     
==========================================
  Files           15       15             
  Lines         1220     1234     +14     
==========================================
+ Hits          1189     1204     +15     
+ Misses          31       30      -1

Impacted Files	Coverage Δ
django_filters/filterset.py	100% <100%> (ø)	⬆️
django_filters/filters.py	97.38% <100%> (+0.09%)	⬆️
django_filters/utils.py	99.1% <0%> (+0.89%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9fcde4...ded646b. Read the comment docs.

[rpkilby]

I'm still not entirely sure why the tests were failing on CI and not locally, but the issue was related to a bad stacklevel on a few of the warnings.

[rpkilby]

@carltongibson, so I think this is ready, but I'm not sure if we want to include this in 1.1

In short, I don't see a clean migration path that accommodates both the old FilterSet strictness behaviors and the proposed strict handling in the views. I also don't think it's really worth the effort even try, given that it would require a bunch of tests that are going to be short lived.

If we merge this, there will be no migration path for strictness, so v1.1 will always raise warnings for the user. Alternatively, this can be merged into a v1.1.1 or v1.2 deprecation/migration release. What do you think?

[carltongibson]

@rpkilby:

... strictness ... there will be no migration path for strictness, so v1.1 will always raise warnings for the user.

Either of:

• Let people silence the warning.
• Merge the rest but just DON'T add the deprecation warning for strictness: Folks are just going to have to notice this in the migration guide when upgrading. (I think that's OK — it's the smoothest migration path — no reason it has to be totally frictionless if that's not OK.)

[rpkilby]

The latter seems preferable. The release notes can make mention of the strictness deprecations instead.

[rpkilby]

Alright, this should be done. I've removed the strictness warnings, but left the deprecation note.

[carltongibson]

OK. This is good. Well done.