Fix Schema warnings #803
Merged
Fix Schema warnings #803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rpkilby
force-pushed
the
schema-warnings
branch
2 times, most recently
from
8752ac7 to
c7e9ecd
Compare
Codecov Report
@@ Coverage Diff @@
## develop #803 +/- ##
==========================================
+ Coverage 97.71% 97.8% +0.08%
==========================================
Files 15 15
Lines 1138 1138
==========================================
+ Hits 1112 1113 +1
+ Misses 26 25 -1
Continue to review full report at Codecov.
|
added 8 commits
October 24, 2017 03:38
rpkilby
force-pushed
the
schema-warnings
branch
from
c7e9ecd to
d4fa8c9
Compare
carltongibson
pushed a commit
that referenced
this pull request
Oct 24, 2017
* Move 'invalid lookup' test to class creation tests * Fix model reference for Filter.label * FilterSet should not require Meta class * Refactor drf backend test views * Add test for Backend.get_filter_class * Fix Backend.get_filter_class * Add Backend.get_schema_fields test for bad fields * Don't suppress TypeErrors in get_schema_fields
carltongibson
pushed a commit
that referenced
this pull request
Oct 24, 2017
* Move 'invalid lookup' test to class creation tests * Fix model reference for Filter.label * FilterSet should not require Meta class * Refactor drf backend test views * Add test for Backend.get_filter_class * Fix Backend.get_filter_class * Add Backend.get_schema_fields test for bad fields * Don't suppress TypeErrors in get_schema_fields
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original purpose of this PR was to fix #802, however it was necessary to make a few other changes.
Changes:
DjangoFilterBackend.get_schema_fields()no longer catches FilterSet class creation errors (ref Automatic __isnull filter field does not work in django-rest-framework usage #743)DjangoFilterBackend.get_filter_class()only performs the model check when applicable. The queryset may not have been provided, or thefilter_classmay not have setMeta.model.Filter.labelhas been fixed to referenceself.modelinstead ofself.parent._meta.model