Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cut 1.1.1 #261

Merged
merged 2 commits into from
May 8, 2018
Merged

Cut 1.1.1 #261

merged 2 commits into from
May 8, 2018

Conversation

swcraig
Copy link
Collaborator

@swcraig swcraig commented May 6, 2018

It has been six months since our last release.

@swcraig swcraig requested a review from gr8bit May 6, 2018 17:14
@gr8bit
Copy link
Collaborator

gr8bit commented May 6, 2018

The actual changes seem to be left out of this PR, are they in master yet @swcraig ?

@swcraig
Copy link
Collaborator Author

swcraig commented May 6, 2018 •
edited
Loading

Yes, the items in the CHANGELOG are in master.

gr8bit
gr8bit approved these changes May 6, 2018
View reviewed changes
Copy link
Collaborator

@gr8bit gr8bit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all fine to me. +1 for 1.1.1

@swcraig
Copy link
Collaborator Author

swcraig commented May 8, 2018

I fixed a subtle typo in the CHANGELOG.

@swcraig swcraig merged commit c3e58fe into carmen-ruby:master May 8, 2018
@swcraig swcraig deleted the cut-1.1.1 branch May 8, 2018 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gr8bit gr8bit gr8bit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@swcraig @gr8bit