Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discord user/role ping/notification support added #1004

Merged
merged 4 commits into from
Nov 19, 2023

Conversation

caronc
Copy link
Owner

@caronc caronc commented Nov 18, 2023

Description:

Related issue (if applicable): #989

Added PING support to Discord related notifications. Syntax supported is as follows:

  • user: <@123>
  • role: <@&456>
  • tag: @everyone

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • No lint errors (use flake8)
  • 100% test coverage

Testing

Anyone can help test this source code as follows:

# Create a virtual environment to work in as follows:
python3 -m venv apprise

# Change into our new directory
cd apprise

# Activate our virtual environment
source bin/activate

# Install the branch
pip install git+https://github.com/caronc/apprise.git@989-discord-notifications

# Test out the changes with the following command:
apprise -vv -b "@everyone and @admin, wake and meet our new user <@123>; <@&456>" \
  "discord://credentials"

@codecov-commenter
Copy link

codecov-commenter commented Nov 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c499762) 99.51% compared to head (ee70d84) 99.51%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1004   +/-   ##
=======================================
  Coverage   99.51%   99.51%           
=======================================
  Files         125      125           
  Lines       16760    16778   +18     
  Branches     3434     3440    +6     
=======================================
+ Hits        16679    16697   +18     
  Misses         70       70           
  Partials       11       11           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@caronc caronc merged commit ccb97bc into master Nov 19, 2023
12 checks passed
@caronc caronc deleted the 989-discord-notifications branch December 29, 2023 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants