Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slight bulletproofing to IFTTT regex handling #436

Merged
merged 1 commit into from
Sep 6, 2021
Merged

Conversation

caronc
Copy link
Owner

@caronc caronc commented Sep 5, 2021

Description:

Related issue (if applicable): n/a

Improved regular expression handling of IFTTT URLs

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • No lint errors (use flake8)
  • 100% test coverage

@codecov-commenter
Copy link

Codecov Report

Merging #436 (cdd9885) into master (81d1ea7) will decrease coverage by 0.92%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##            master     #436      +/-   ##
===========================================
- Coverage   100.00%   99.07%   -0.93%     
===========================================
  Files           95       94       -1     
  Lines        12145    11999     -146     
  Branches      2048     1924     -124     
===========================================
- Hits         12145    11888     -257     
- Misses           0      102     +102     
- Partials         0        9       +9     
Impacted Files Coverage Δ
apprise/plugins/NotifyIFTTT.py 100.00% <ø> (ø)
apprise/plugins/NotifyXMPP/SliXmppAdapter.py 26.25% <0.00%> (-73.75%) ⬇️
apprise/Apprise.py 92.85% <0.00%> (-7.15%) ⬇️
apprise/URLBase.py 95.43% <0.00%> (-4.57%) ⬇️
apprise/AppriseLocale.py 97.46% <0.00%> (-2.54%) ⬇️
apprise/plugins/NotifyBase.py 97.67% <0.00%> (-2.33%) ⬇️
apprise/config/ConfigBase.py 98.18% <0.00%> (-1.82%) ⬇️
apprise/plugins/NotifyBoxcar.py 98.26% <0.00%> (-1.74%) ⬇️
apprise/plugins/NotifyFCM/oauth.py 98.33% <0.00%> (-1.67%) ⬇️
apprise/plugins/NotifyD7Networks.py 98.47% <0.00%> (-1.53%) ⬇️
... and 79 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81d1ea7...cdd9885. Read the comment docs.

@caronc caronc merged commit e20fce6 into master Sep 6, 2021
@caronc caronc deleted the ifttt-regex-update branch September 18, 2021 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants