-
-
Notifications
You must be signed in to change notification settings - Fork 433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Synology Chat support #944
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #944 +/- ##
========================================
Coverage 99.51% 99.51%
========================================
Files 125 126 +1
Lines 16760 16868 +108
Branches 3434 3457 +23
========================================
+ Hits 16679 16787 +108
Misses 70 70
Partials 11 11 ☔ View full report in Codecov by Sentry. |
Reached out to Synology Comunity for testing support |
Hi, I have conducted tests on my own Synology NAS and successfully sent them out via
Since Synology Chat does not provide any interface, I’m currently unable to ascertain the root cause of the issue. However, I can confirm that there is no issue with the network link between my test machine and Synology Chat. Thank you for your work. If you currently don’t have Synology Chat, please inform me when the next version is released, and I would be more than willing to assist you in testing it. |
What happens if you just use I'm confused because in your example you have Is your The fact it is sending okay though without an issue has me confused, i'll need to see if i can figure out why it doesn't work. I don't have Synology device unfortunately, so i am relying on kind people like you to test; thanks again for doing this! |
22ee448
to
b0678dd
Compare
My NAS is correctly configured with an SSL certificate on port 8888, and I have also tried the |
I suspect the problem is in the |
In synochat, the
|
Thank you @hhhguany for all our great effort, support and the links you shared. I followed your advice; i'm looking forward to hearing back from you how it went! 🚀 |
It's working fine!Thanks for your work. |
Description:
Related issue (if applicable): #908
Added Synology Chat Support
Syntax
Valid syntax is as follows:
synology://{hostname}}/{token}
synology://{hostname}:{port}/{token}
synology://{user}:{password}@{hostname}/{token}
synology://{user}:{password}@{hostname}:{port}/{token}
The secure versions (https):
synologys://{hostname}/{token}
synologys://{hostname}:{port}/{token}
synologys://{user}:{password}@{hostname}/{token}
synologys://{user}:{password}@{hostname}:{port}/{token}
Parameter Breakdown
Example
Send a Synology Chat notification to our web server listening on port 80:
New Service Completion Status
%global common_description
Checklist
flake8
)Testing
Anyone can help test this source code as follows: