Update link valiation to include known protocols #109
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the
$validate_links()
method to now include an allowed list of protocols and will error if the protocol is not within the list. I have derived the list of protocols from Wordpress: https://developer.wordpress.org/reference/functions/wp_allowed_protocols/#returnLinks with protocols not within our allow list will be flagged:
I have also updated the error messages and documentation around link validation.
This will fix #107 and make sure that fishtree-attempt/instructor-training#5 actually throws a warning