Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more verbose validation errors #79

Merged
merged 5 commits into from
Feb 18, 2022
Merged

Conversation

tobyhodges
Copy link
Member

If you prioritise brevity in these messages, then feel free to reject this.

@zkamvar
Copy link
Contributor

zkamvar commented Feb 18, 2022

Not at all! I think this is great! I will update the snapshot tests and merge it!

@zkamvar
Copy link
Contributor

zkamvar commented Feb 18, 2022

N.B. the impetus for this PR is from carpentries/sandpaper#255 (comment)

@zkamvar
Copy link
Contributor

zkamvar commented Feb 18, 2022

@tobyhodges, I have added you as a contributor, is that okay with you?

@tobyhodges
Copy link
Member Author

👍

@zkamvar zkamvar merged commit f41400e into carpentries:main Feb 18, 2022
@zkamvar
Copy link
Contributor

zkamvar commented Feb 18, 2022

Congratulations on your first contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants