-
-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
document custom logo #197
document custom logo #197
Conversation
Thank you!Thank you for your pull request 😃 🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}. If you have files that automatically render output (e.g. R Markdown), then you should check for the following:
Rendered Changes🔍 Inspect the changes: https://github.com/carpentries/sandpaper-docs/compare/md-outputs..md-outputs-PR-197 The following changes were observed in the rendered markdown documents:
What does this mean?If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible. This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation. ⏱️ Updated at 2024-07-26 10:14:25 +0000 |
Thanks @ErinBecker, looks good. |
Prompted by this, I have taken a closer look. There is some inconsistency already in how package names, filenames, and YAML variable names are formatted across the site, but I have suggested a few changes to try to keep things roughly in line. |
Co-authored-by: Toby Hodges <tobyhodges@carpentries.org>
Co-authored-by: Toby Hodges <tobyhodges@carpentries.org>
Co-authored-by: Toby Hodges <tobyhodges@carpentries.org>
Based on changes to carpentries/sandpaper#585
Following updates in carpentries/sandpaper-docs#197 Co-authored-by: Erin Becker <ebecker@carpentries.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
adding a couple of options missing from the list. These options should also be added to the list for the carpentry
option.
episodes/editing.md
Outdated
carpentry_description | ||
: (Optional) Full organisation name. Not needed when carpentry is swc, dc, lc, or cp. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
carpentry_description | |
: (Optional) Full organisation name. Not needed when carpentry is swc, dc, lc, or cp. | |
carpentry_description | |
: (Optional) Full organisation name. Not needed when carpentry is swc, dc, lc, cp, incubator, or lab. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have adjusted the lists and will merge this now. Thanks @ErinBecker! 🙌
Auto-generated via {sandpaper} Source : 666e14a Branch : md-outputs Author : GitHub Actions <actions@github.com> Time : 2024-07-26 10:35:50 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : 2a7b850 Branch : main Author : Toby Hodges <tobyhodges@carpentries.org> Time : 2024-07-26 10:34:54 +0000 Message : Merge pull request #197 from carpentries/custom-carpentry document custom logo
Auto-generated via {sandpaper} Source : 666e14a Branch : md-outputs Author : GitHub Actions <actions@github.com> Time : 2024-07-26 10:35:50 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : 2a7b850 Branch : main Author : Toby Hodges <tobyhodges@carpentries.org> Time : 2024-07-26 10:34:54 +0000 Message : Merge pull request #197 from carpentries/custom-carpentry document custom logo
* Allow custom carpentry setting * Add optional `carpentry_description` * Add `carpentry_description` to the config template * Test that `which_carpentry` works correctly * Update documentation reference Following updates in carpentries/sandpaper-docs#197 Co-authored-by: Erin Becker <ebecker@carpentries.org> * Fix for pkgdown 2.1.0 adding anchors to sections * Revert last commit, add pinned pkgdown version * Update DESCRIPTION Revert package pinning as it doesn't seem to be respected in dependency calculations from fresh installs - something I don't really understand with R. This means that sandpaper will continue to build but will have the duplicate anchors for h2 sections, and tests will fail. --------- Co-authored-by: Erin Becker <ebecker@carpentries.org> Co-authored-by: Robert Davey <robertdavey@carpentries.org>
Auto-generated via {sandpaper} Source : 666e14a Branch : md-outputs Author : GitHub Actions <actions@github.com> Time : 2024-07-26 10:35:50 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : 2a7b850 Branch : main Author : Toby Hodges <tobyhodges@carpentries.org> Time : 2024-07-26 10:34:54 +0000 Message : Merge pull request #197 from carpentries/custom-carpentry document custom logo
Auto-generated via {sandpaper} Source : 666e14a Branch : md-outputs Author : GitHub Actions <actions@github.com> Time : 2024-07-26 10:35:50 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : 2a7b850 Branch : main Author : Toby Hodges <tobyhodges@carpentries.org> Time : 2024-07-26 10:34:54 +0000 Message : Merge pull request #197 from carpentries/custom-carpentry document custom logo
Auto-generated via {sandpaper} Source : 666e14a Branch : md-outputs Author : GitHub Actions <actions@github.com> Time : 2024-07-26 10:35:50 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : 2a7b850 Branch : main Author : Toby Hodges <tobyhodges@carpentries.org> Time : 2024-07-26 10:34:54 +0000 Message : Merge pull request #197 from carpentries/custom-carpentry document custom logo
This PR adds documentation for how to configure your lesson to use a custom logo (other than one of The Carpentries logos that are included in the template). This should be reviewed and merged along with carpentries/sandpaper#585.
I would particularly appreciate review of the clarity of the instructions, as well as whether I've used
code
formatting consistently with best practices (or at least consistently with the rest of our documentation!).