Merge pull request #476 from carpentries/avoid-gert-config-449

do not use gert for pkgdown config

DESCRIPTION

@@ -1,6 +1,6 @@
 Package: sandpaper
 Title: Create and Curate Carpentries Lessons
-Version: 0.12.2
+Version: 0.12.3
 Authors@R: c(
     person(given = "Zhian N.",
            family = "Kamvar",

NEWS.md

@@ -1,3 +1,9 @@
+# sandpaper 0.12.3 (2023-06-01)
+
+* A bug where the git credentials are accidentally changed when a lesson is
+  built is fixed by no longer querying git author when the lesson is built.
+  (reported: @joelnitta, @velait, and @zkamvar, #449; fixed: @zkamvar, #476).
+
 # sandpaper 0.12.2 (2023-05-29)
 
 ## BUG FIX

R/create_site.R

@@ -10,7 +10,6 @@ create_site <- function(path) {
 
   if (!isTRUE(chk$description)) {
     fs::file_create(fs::path(path_site(path), "DESCRIPTION"))
-    check_git_user(path)
     create_description(path)
   }
 

R/utils.R

@@ -166,7 +166,7 @@ create_site_readme <- function(path) {
 
 create_description <- function(path) {
   yaml <- yaml::read_yaml(path_config(path), eval.expr = FALSE)
-  the_author <- paste(gert::git_signature_default(path), "[aut, cre]")
+  the_author <- paste("Jo Carpenter <team@carpentries.org> [aut, cre]")
   the_author <- utils::as.person(the_author)
   desc <- desc::description$new("!new")
   desc$del(c("BugReports", "LazyData"))

tests/testthat/test-build_lesson.R

@@ -33,6 +33,15 @@ if (rmarkdown::pandoc_available("2.11")) {
 
 pkg <- pkgdown::as_pkgdown(fs::path_dir(sitepath))
 
+
+test_that("The lesson contact is always team@carpentries.org", {
+  dsc <- desc::description$new(sub("docs[/]?", "DESCRIPTION", sitepath))
+  auth <- eval(parse(text = dsc$get_field("Authors@R")))
+  expect_equal(as.character(auth),
+    "Jo Carpenter <team@carpentries.org> [aut, cre]")
+})
+
+
 test_that("build_lesson() also builds the extra pages", {
   skip_if_not(rmarkdown::pandoc_available("2.11"))
   expect_true(fs::dir_exists(sitepath))