Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

devel {renv} changed its messaging again, breaking one test #484

Closed
zkamvar opened this issue Jun 27, 2023 · 1 comment · Fixed by #486
Closed

devel {renv} changed its messaging again, breaking one test #484

zkamvar opened this issue Jun 27, 2023 · 1 comment · Fixed by #486
Labels
bug Something isn't working renv: future An issue that is caused by an upcoming release of {renv}

Comments

@zkamvar
Copy link
Contributor

zkamvar commented Jun 27, 2023

One of my brittle tests is failing because the devel version of {renv} now prints "loaded with lesson-requirements profile" instead of "loaded with profile (lesson-requirements)", which breaks my test.

That being said, {renv} still works as expected otherwise. The solution would be to remove the parens from that test.

══ Failed tests ════════════════════════════════════════════════════════════════
── Failure ('test-utils-callr.R:44:3'): callr_build_episode_md() works with Rmarkdown using renv ──
`\.` does not match "\\(lesson-requirements\\)".
Actual value: "# Loading renv \[0\.17\.3-88; rstudio/renv@547832d\] -----------------------------\\n- Project '/tmp/RtmpsOHZyg/working_dir/RtmpOs2m7A/file32d4656eac79/lesson-example' loaded with lesson-requirements profile\.\\n- The project is currently out-of-sync\.\\n- Use `renv::status\(\)` for more details\."
Backtrace:1. ├─base::suppressMessages(...) at test-utils-callr.R:44:2
 2. │ └─base::withCallingHandlers(...)
 3. ├─... %>% expect_output("\\(lesson-requirements\\)") at test-utils-callr.R:45:2
 4. └─testthat::expect_output(., "\\(lesson-requirements\\)")
 5.   └─testthat::expect_match(...)
 6.     └─testthat:::expect_match_(...)
@zkamvar zkamvar added bug Something isn't working renv: future An issue that is caused by an upcoming release of {renv} labels Jun 27, 2023
@zkamvar
Copy link
Contributor Author

zkamvar commented Jun 27, 2023

cc @carpentries/workbench-maintainers

@zkamvar zkamvar changed the title devel {renv} changed its messaging again, breaking one devel {renv} changed its messaging again, breaking one test Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working renv: future An issue that is caused by an upcoming release of {renv}
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant