Fix test for {renv}

[zkamvar]

This fixes a single test for {renv} due to a difference in output it created.

Note: because this only affects one test and the devel version of {renv}, the new version does not need to be released after this is merged.

This will fix #484

[froggleston]

LGTM 👍

[zkamvar]

Now it appears that there is a problem with R-devel and the internal .make_numeric_version() throwing a new warning, which was introduced into devel R two days ago: wch/r-source@1338a95

We are now inundated with new warnings in R-devel and it's changing our snapshot tests. I believe the solution is to use the devel version of {rmarkdown} for our tests. The solution is to fix the 0 here to be "0":

sandpaper/R/check_pandoc.R

Line 41 in cde8907

if (pan$version > 0) {

Condition
  Warning in `.make_numeric_version()`:
  invalid non-character version specification 'x' (type: double)

I suspect this is actually coming from {rmarkdown} because this commit (rstudio/rmarkdown@01a1737) references https://bugs.r-project.org/show_bug.cgi?id=18548, which makes this comparison illegal:

numeric_version("1.5") == 1.5
#> [1] TRUE

^{Created on 2023-06-30 with reprex v2.0.2}

Warnings

── Failure ('test-check_pandoc.R:12:3'): check_pandoc() throws a message about installation [ansi] ──
Snapshot of code has changed:
old[1:5] vs new[1:8]
  Code
    expect_error(check_pandoc(pv = "42"), "Incorrect pandoc version")
+ Condition
+   Warning in `.make_numeric_version()`:
+   invalid non-character version specification 'x' (type: double)
  Message
     sandpaper requires pandoc version 42 or higher.
    ! You have pandoc version [version masked for testing] in '[path masked for testing]'

* Run `testthat::snapshot_accept('check_pandoc')` to accept the change.
* Run `testthat::snapshot_review('check_pandoc')` to interactively review the change.
── Failure ('test-check_pandoc.R:12:3'): check_pandoc() throws a message about installation [unicode] ──
Snapshot of code has changed:
old[1:5] vs new[1:8]
  Code
    expect_error(check_pandoc(pv = "42"), "Incorrect pandoc version")
+ Condition
+   Warning in `.make_numeric_version()`:
+   invalid non-character version specification 'x' (type: double)
  Message
     sandpaper requires pandoc version 42 or higher.
    ! You have pandoc version [version masked for testing] in '[path masked for testing]'

* Run `testthat::snapshot_accept('check_pandoc')` to accept the change.
* Run `testthat::snapshot_review('check_pandoc')` to interactively review the change.
── Failure ('test-check_pandoc.R:12:3'): check_pandoc() throws a message about installation [fancy] ──
Snapshot of code has changed:
old[1:5] vs new[1:8]
  Code
    expect_error(check_pandoc(pv = "42"), "Incorrect pandoc version")
+ Condition
+   Warning in `.make_numeric_version()`:
+   invalid non-character version specification 'x' (type: double)
  Message
     sandpaper requires pandoc version 42 or higher.
    ! You have pandoc version [version masked for testing] in '[path masked for testing]'

* Run `testthat::snapshot_accept('check_pandoc')` to accept the change.
* Run `testthat::snapshot_review('check_pandoc')` to interactively review the change.
── Failure ('test-check_pandoc.R:18:3'): check_pandoc throws a message about installation for RStudio [plain] ──
Snapshot of code has changed:
old[1:6] vs new[1:9]
  Code
    expect_error(check_pandoc(pv = "42", rv = "94"), "Incorrect pandoc version",
    fixed = TRUE)
+ Condition
+   Warning in `.make_numeric_version()`:
+   invalid non-character version specification 'x' (type: double)
  Message
     sandpaper requires pandoc version 42 or higher.
    ! You have pandoc version [version masked for testing] in '[path masked for testing]'

* Run `testthat::snapshot_accept('check_pandoc')` to accept the change.
* Run `testthat::snapshot_review('check_pandoc')` to interactively review the change.
── Failure ('test-check_pandoc.R:18:3'): check_pandoc throws a message about installation for RStudio [ansi] ──
Snapshot of code has changed:
old[1:6] vs new[1:9]
  Code
    expect_error(check_pandoc(pv = "42", rv = "94"), "Incorrect pandoc version",
    fixed = TRUE)
+ Condition
+   Warning in `.make_numeric_version()`:
+   invalid non-character version specification 'x' (type: double)
  Message
     sandpaper requires pandoc version 42 or higher.
    ! You have pandoc version [version masked for testing] in '[path masked for testing]'

* Run `testthat::snapshot_accept('check_pandoc')` to accept the change.
* Run `testthat::snapshot_review('check_pandoc')` to interactively review the change.
── Failure ('test-check_pandoc.R:18:3'): check_pandoc throws a message about installation for RStudio [unicode] ──
Snapshot of code has changed:
old[1:6] vs new[1:9]
  Code
    expect_error(check_pandoc(pv = "42", rv = "94"), "Incorrect pandoc version",
    fixed = TRUE)
+ Condition
+   Warning in `.make_numeric_version()`:
+   invalid non-character version specification 'x' (type: double)
  Message
     sandpaper requires pandoc version 42 or higher.
    ! You have pandoc version [version masked for testing] in '[path masked for testing]'

* Run `testthat::snapshot_accept('check_pandoc')` to accept the change.
* Run `testthat::snapshot_review('check_pandoc')` to interactively review the change.
── Failure ('test-check_pandoc.R:18:3'): check_pandoc throws a message about installation for RStudio [fancy] ──
Snapshot of code has changed:
old[1:6] vs new[1:9]
  Code
    expect_error(check_pandoc(pv = "42", rv = "94"), "Incorrect pandoc version",
    fixed = TRUE)
+ Condition
+   Warning in `.make_numeric_version()`:
+   invalid non-character version specification 'x' (type: double)
  Message
     sandpaper requires pandoc version 42 or higher.
    ! You have pandoc version [version masked for testing] in '[path masked for testing]'

* Run `testthat::snapshot_accept('check_pandoc')` to accept the change.
* Run `testthat::snapshot_review('check_pandoc')` to interactively review the change.

[zkamvar]

@carpentries/workbench-maintainers, please review (and subsequently merge if it looks cromulent) this when you get the chance.

[froggleston]

I completely agree that this is weird. The function is make_numeric_version but expects a char as input. Strange. They check for ischaracter() so why not also check for isnumeric() and support both? shrugs (edit: hmm I guess 1.3.5 for example isn't numeric so would need to be a char at any rate)