draft changes in contributing-md #407
Conversation
I think some links should be modified at the end, I do not know about shell-novice and co
There was a problem hiding this comment.
This looks good to me. Thank you for starting this!
I think the entire "Where to contribute" section can be rewritten or removed because that served as a signpost when the tools and content were bundled together, but that can be addressed later.
Could you add your name to the DESCRIPTION as a contributor? (here is a guide for the format).
I am currently trying waiting for #405 to pass and then I will merge this and fix any tests that may need fixing.
| before starting work. | ||
| Please do *not* work directly in your `gh-pages` branch, | ||
| since that will make it difficult for you to work on other contributions. | ||
| discuss with the maintainer about what branch to use before starting to work. |
There was a problem hiding this comment.
I believe this entire sentence can be deleted since GitHub flow is described below.
There was a problem hiding this comment.
I think I would keep it especially for people used to the old workflow that used the gh-page branch as the published copy.
| before starting work. | ||
| Please do *not* work directly in your `gh-pages` branch, | ||
| since that will make it difficult for you to work on other contributions. | ||
| discuss with the maintainer about what branch to use before starting to work. |
There was a problem hiding this comment.
I think I would keep it especially for people used to the old workflow that used the gh-page branch as the published copy.
|
This is currently failing because the main branch needs to be merged to address the fixes from #405. I will go ahead and do that from my end. |
|
Sorry about the lack of communication on my end; Aside from the chaos of the last week, I had an emergency situation yesterday that took me away from my desk and could not address this. Honestly, it never usually takes me this long to address issues, especially something as straightforward as modifying a template file.
For me, it is valuable to keep an acknowledgement of how we used to do things so that folks who transition to using The Workbench from styles know the difference, but it should be an aside. My reasoning is that this document should accurately describe our current practices to allow people to quickly and confidently make a contribution. The discussion of the branch names was a relic from a time when lessons often had a default branch that was different than the generally accepted default branch (and even at that, our lesson repositories were not consistent in this respect), which is now no longer relevant. |
|
no problem, you are still one of the fastest people around even when you fell you are slow :) I simplified a bit, taking our remnants from previous workflows. |
|
Thank you @jcolomb! T |
I think some links should be modified at the end, I do not know about shell-novice and co
Please delete this line and the text below before submitting your contribution.
Thanks for contributing! If this contribution is for instructor training, please send an email to checkout@carpentries.org with a link to this contribution so we can record your progress. You’ve completed your contribution step for instructor checkout just by submitting this contribution.
Please keep in mind that lesson maintainers are volunteers and it may be some time before they can respond to your contribution. Although not all contributions can be incorporated into the lesson materials, we appreciate your time and effort to improve the curriculum. If you have any questions about the lesson maintenance process or would like to volunteer your time as a contribution reviewer, please contact The Carpentries Team at team@carpentries.org.