Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keep current episode number in sidebar #472

Merged
merged 8 commits into from
May 26, 2023
Merged

Conversation

zkamvar
Copy link
Contributor

@zkamvar zkamvar commented May 26, 2023

This will keep the current episode number in the sidebar.

Note that the sidebar mechanism really needs to be overhauled because this is
a bit over-engineered.

This will fix #432

@zkamvar zkamvar marked this pull request as ready for review May 26, 2023 18:13
@zkamvar
Copy link
Contributor Author

zkamvar commented May 26, 2023

@zkamvar
Copy link
Contributor Author

zkamvar commented May 26, 2023

😭 HADLEY IS BREAKING MY BRITTLE TESTS AGAIN rstudio/renv#1350

── Failure ('test-manage_deps.R:60:3'): manage_deps() will create a renv folder ──
`\.` does not match "knitr".
Actual value: "→ Searching for and installing available dependencies\\n→ Recording changes in lockfile\\n\\n\\nprocessing file: /tmp/RtmpOekirg/working_dir/RtmpnKnfGb/file315b3eb77a60/lesson-example/episodes/introduction\.Rmd\\noutput file: /tmp/RtmpOekirg/working_dir/RtmpnKnfGb/file315b3eb77a60/lesson-example/site/built/introduction\.md\\n"
Backtrace:1. ├─base::suppressMessages(...) at test-manage_deps.R:60:2
 2. │ └─base::withCallingHandlers(...)
 3. ├─... %>% expect_output("knitr") at test-manage_deps.R:61:4
 4. └─testthat::expect_output(., "knitr") at magrittr/R/pipe.R:136:2
 5.   └─testthat::expect_match(...) at testthat/R/expect-output.R:47:4
 6.     └─testthat:::expect_match_(...) at testthat/R/expectations-matches.R:42:2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sidebar current page item should not hide episode number
1 participant