Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better child minder #513

Merged
merged 27 commits into from
Sep 26, 2023
Merged

Better child minder #513

merged 27 commits into from
Sep 26, 2023

Conversation

zkamvar
Copy link
Contributor

@zkamvar zkamvar commented Sep 14, 2023 •
edited
Loading

This is paired with carpentries/pegboard#137 to better solve the processing of child documents in lessons:

  • update processing of child documents for the build database
  • new vignette to explain the caveats related to child documents
  • allow all subfolders to contain asset folders (makes it easier to include child files for non-episode content)
  • fixes bug where the child files were accidentally being counted as markdown content to process
  • use dev mode auto for pkgdown

Testing

You can test this by checking out the branch and running the tests inside your local clone of {sandpaper} using The usethis pull request helpers.

usethis::pr_fetch(513)
devtools::install_github("carpentries/pegboard#137")
devtools::test()

@zkamvar
filter out asset contents in resource discovery
e1b4fc1 
This is a small bug from our initial overview lesson support
@zkamvar
update NEWS
30cbf6c
@zkamvar
copy assets from all subfolders
5ca6bda
@zkamvar
do not use purrr when vapply is right there
7000aff
@zkamvar
[broken] attempt to use new pegboard
7bfc2a6 
There are now still some problems with file ordering that I'm really
beating myself up for -_-
@zkamvar
set names rel path names for child list
152beef 
I was getting in trouble because the order of the files from pegboard
and sandpaper's file listing system do not match (because sandpaper
cares about more files).

The bed that I made for pegboard initially set the names of the files to
be the file names without the paths and that was it, but in the
database, the IDs for the files were the names of the files relative to
the lesson path and thus it caused confusion. Fixing the relative names
solved this problem (and likely I should adopt this for pegboard itself
:/)
@zkamvar
reformat test code
a2c79ac
@zkamvar
rename hash functions; remove old code; document
d885b62
@zkamvar
fix pkgdown
161ddf4
@zkamvar
make dev version
89e2812
@zkamvar
fix get_build_slug for child file; add quiet arg
66bb42e
zkamvar added a commit to carpentries-incubator/managing-computational-projects that referenced this pull request Sep 15, 2023
@zkamvar
fix fences in 12-analysis.md
a0f3d05 
I am testing out carpentries/sandpaper#513 and carpentries/pegboard#137 to help with validation and building, which will fix carpentries/workbench#68

There was an error because the div fences were too close to the text, so I added spaces.
@zkamvar zkamvar mentioned this pull request Sep 15, 2023
Open
@zkamvar zkamvar marked this pull request as ready for review September 15, 2023 18:55
@zkamvar zkamvar mentioned this pull request Sep 18, 2023
Merged
@zkamvar
Copy link
Contributor Author

zkamvar commented Sep 22, 2023

UGH. The windows tests are failing because pandoc nightly is being dramatic 😩

@zkamvar zkamvar mentioned this pull request Sep 22, 2023
Merged
@zkamvar zkamvar merged commit c0cdb6e into main Sep 26, 2023
@zkamvar zkamvar deleted the better-child-minder branch September 26, 2023 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@zkamvar