Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatically open new episodes for editing in interactive sessions #534

Merged
merged 8 commits into from
Nov 23, 2023
Merged

Automatically open new episodes for editing in interactive sessions #534

merged 8 commits into from
Nov 23, 2023

Conversation

milanmlft
Copy link
Contributor

@milanmlft milanmlft commented Oct 26, 2023 •
edited
Loading

Automatically open newly created episodes for editing in interactive sessions.
Avoids a few extra mouse clicks/keyboard strokes and improves Developer QoL 🙂

@milanmlft milanmlft changed the title Open new episodes for editing in interactive sessions Automatically open new episodes for editing in interactive sessions Oct 30, 2023
@zkamvar zkamvar added the Developer QOL 👷 This feature enhances the developer quality of life label Nov 6, 2023
@zkamvar
Copy link
Contributor

zkamvar commented Nov 22, 2023

Thank you! This looks good to me. I've added a NEWS item and will merge it when it passes.

@zkamvar
sprinkle open args through create_episode family
a27d2b8
@zkamvar
make sure create_episode() behaves in examples
3f54521 
That is, make sure it does not accidentally open a file when
lessons are being created or when running examples.
@zkamvar
silence create_episode() msg in tests
80855ae 
We have the tests to ensure the basic functionality works and we know
that usethis is testing for the messaging funcationality, we do not need
to further test it and it is better to silence the messages than test
for them.
@zkamvar
Merged origin/main into milanmlft-milanmlft/open-episode
833269f
@zkamvar
Copy link
Contributor

zkamvar commented Nov 23, 2023

Ah, turns out because of the messaging involved, I had to do a few more things 😅

  1. add open = FALSE to all the uses in tests, examples, and inside the create_lesson() function
  2. wrap all instances in tests with suppressMessages()
  3. re-document
  4. merge main (to allow windows tests to pass)

@zkamvar zkamvar merged commit 558f4bb into carpentries:main Nov 23, 2023
12 checks passed
@milanmlft milanmlft deleted the milanmlft/open-episode branch November 23, 2023 07:55
@milanmlft
Copy link
Contributor Author

Thanks @zkamvar!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Developer QOL 👷 This feature enhances the developer quality of life
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@milanmlft @zkamvar