Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI test matrix #179

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update CI test matrix #179

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,14 +8,14 @@ jobs:
strategy:
fail-fast: false
matrix:
ruby: [ '2.5', '2.6', '2.7', '3.0', '3.1', '3.2', jruby ]
ruby: [ '3.0', '3.1', '3.2', '3.3', head, jruby ]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for responding late 🙇‍♂️
Would you mind keeping 2.x Rubies? If this was an app it's fine, but libraries, including carrierwave-aws, are better be permissive on its dependencies I think, as users may have a reason that prevents from upgrading.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your reply. I'm not sure what the consensus is on unmaintained Ruby versions. I'm obviously not in a position to decide that. But I think that supporting old versions also leads to people not updating their software. In the end that means that they are running insecure software. Also, people with old Ruby versions might still be using old versions of this gem. Maybe someone else has an opinion on this topic. I can also just add the old versions back, if that's the prevailing opinion.

gemfile: [ gemfiles/carrierwave-3.gemfile ]
include:
- ruby: '3.2'
- ruby: '3.3'
gemfile: gemfiles/carrierwave-2.gemfile
- ruby: '3.2'
- ruby: '3.3'
gemfile: gemfiles/carrierwave-master.gemfile
runs-on: ubuntu-20.04
runs-on: ubuntu-latest
env:
S3_BUCKET_NAME: test-bucket
S3_ACCESS_KEY: DummyAccessKey
Expand All @@ -33,7 +33,7 @@ jobs:
-v /tmp/data:/data \
-v /tmp/config:/root/.minio \
minio/minio server /data
- uses: actions/checkout@v2
- uses: actions/checkout@v4
- name: Set up Ruby
uses: ruby/setup-ruby@v1
with:
Expand All @@ -46,11 +46,11 @@ jobs:
name: RuboCop
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v4
- name: Set up Ruby
uses: ruby/setup-ruby@v1
with:
ruby-version: "3.2"
ruby-version: '3.3'
bundler-cache: true
- name: Run check
run: bundle exec rake rubocop