Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use RFC2396_REGEXP explicitly #2760

Merged
merged 1 commit into from
Nov 9, 2024
Merged

Conversation

ollym
Copy link
Contributor

@ollym ollym commented Nov 7, 2024

Because uri > 1.0 switched to RFC3986 as the default parser

Fixes #2759

Because uri > 1.0 switched to RFC3986 as the default parser
@ollym
Copy link
Contributor Author

ollym commented Nov 7, 2024

@mshibuya if you can take a look as the patch changes you made to the original file. Thanks

n-rodriguez added a commit to jbox-web/remotipart that referenced this pull request Nov 8, 2024
Fix NameError: uninitialized constant URI::REGEXP
See: carrierwaveuploader/carrierwave#2760
@mshibuya mshibuya merged commit 8485fee into carrierwaveuploader:master Nov 9, 2024
14 checks passed
@mshibuya
Copy link
Member

mshibuya commented Nov 9, 2024

Thank you!

@ollym ollym deleted the patch-1 branch November 9, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incompatible with URI >=1.0.0
2 participants