Add KTypeArrayList removeAt and rename remove to removeElement. #247
Conversation
| final int deleted = elementsCount - to; | ||
| this.elementsCount = to; | ||
| /* #if ($TemplateOptions.KTypeGeneric) */ | ||
| Arrays.fill(buffer, elementsCount, elementsCount + deleted, Intrinsics.empty()); |
There was a problem hiding this comment.
Do you think it's going to be faster this way? Those null assignments should be within the same cache line, so super-fast already? And previously it'd zero the removed slot, now it doesn't. Don't know if it makes a difference in practice.
There was a problem hiding this comment.
Since you asked the question, I did a benchmark running removeAll on lists of size 10, 100, 1_000, 10_000, and with four categories of number of duplicate elements to make the removal longer.
- Surprisingly (to me) I see no perf difference for primitive IntArrayList with and without zeroing removed slots.
- For ObjectArrayList, the new version with Arrays.fill is 20% faster for large lists.
So I would tend to keep this new code, unless you see an interest in zeroing removed slots for primitives. BTW the KTypeSlack implementation of pop was already not zeroing removed slots, and that suggested me to do the same for list.
There was a problem hiding this comment.
Thank you for running the benchmark. LGTM.
Optimize removal methods to only dereference removed elements when the list is generic.
bruno-roustant
force-pushed
the
container_remove
branch
from
012bde5
to
39ba537
Compare
Optimize removal methods to only dereference removed elements when the list is generic.
Add test and make several existing tests run on primitive types.