This repository has been archived by the owner on Oct 25, 2023. It is now read-only.
Issue 76 #78
Merged
Issue 76 #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carsakiller
added
bug
Closed
|
Requesting review as I just want a brief check over to see if this would interfere with the companion at all. |
CrazyFluffyPony
approved these changes
Aug 24, 2022
carsakiller
added a commit
that referenced
this pull request
Nov 15, 2022
* fix: move g_savedata init * version bump
carsakiller
added a commit
that referenced
this pull request
Nov 15, 2022
* fix: move g_savedata init * version bump
carsakiller
added a commit
that referenced
this pull request
Nov 15, 2022
* fix: move g_savedata init * version bump
carsakiller
added a commit
that referenced
this pull request
Nov 15, 2022
* fix: move g_savedata init * version bump
carsakiller
added a commit
that referenced
this pull request
Nov 30, 2022
* fix: move g_savedata init * version bump
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like
onVehicleSpawn()is getting called beforeonCreate()so we cannot guarantee thatg_savedatais initialized before being needed.This leads to
nilexceptions, especially when syncing with the companion web app.This PR moves the initializing of
g_savedatavariables to be executed immediately and not inonCreate()to hopefully fix this issue.Fixes #76, #75
Also seems to fix #77, I assume it was linked as
onVehicleSpawn()was getting called beforeonCreate()and it was corruptingG_vehiclessomehow.