Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Synchronization with next-click-counts hotkey #76

Closed
leonardmitri opened this issue Jul 26, 2020 · 5 comments · Fixed by #91
Closed

Feature request: Synchronization with next-click-counts hotkey #76

leonardmitri opened this issue Jul 26, 2020 · 5 comments · Fixed by #91

Comments

@leonardmitri
Copy link

Just like in the alternative -Subtitle buddy- adding the next-click-counts to the video player and the subtitles so they play at the same time would be much easier.
Ive loving this penguin so far!

@leonardmitri leonardmitri changed the title Synchronization with next-click-counts hotkey Feature request: Synchronization with next-click-counts hotkey Jul 26, 2020
@carsonip
Copy link
Owner

Thanks for your support! I'll have to look into the feature and see if it is good/feasible to add to Penguin Subtitle Player.

@leonardmitri
Copy link
Author

Thank you for your work!!!

@EmilJunker
Copy link

Any update on this? I think it would be a useful feature.

Maybe this could be implemented via the QEvent::FocusOut event. So when next-click-counts is activated and I click the play button, it shouldn't start playing right away but wait until the window loses focus (i.e. I click somewhere outside the window).

Maybe this can help (different use case but similar idea):
https://www.qtcentre.org/threads/20642-How-to-get-mouse-click-events-outside-the-Qt-window

@carsonip
Copy link
Owner

Apparently FocusOut doesn't work for some reasons, but it is possible to implement this feature by spawning a regular window on next-click-counts button click and then listen to WindowDeactivate event.

carsonip added a commit that referenced this issue Oct 30, 2021
carsonip added a commit that referenced this issue Oct 30, 2021
carsonip added a commit that referenced this issue Oct 30, 2021
@EmilJunker
Copy link

@carsonip
Thank you so much for this neat feature!

starts the timer after the first click outside of the subtitle player for easier sync between video player and subtitle player. Activate this feature by right clicking on the play button.

Would it be possible to also add "next click counts" for pausing? So when I right click the pause button, it waits for the next click before it actually pauses.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants