fix: add _wrap function and support multiple Moderation responses #3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Big Changes:
_instrument_*()
function, adds a common_wrap()
function that instruments each API call type listed in the newTO_WRAP
dict. The hope is that this will make the code easier to maintain moving forward, since it makes "what does instrumentation mean" common across all the api calls, and it makes "what is getting instrumented" effectively just a series of configurations that can be tweaked and added to as necessary.openai.Moderation.create()
instrumentation to support multiple response values (and changes the underlying test expectations)Small Changes:
wrapt
, just thewrap_function_wrapper
that we need.Tracer
fromopentelemetry.trace
import, since we don't really need it?math.inf
for the equivalentfloat('inf')
so that we can drop themath
import altogether.Motivation
Moderation.create()
Testing
Tests pass locally, and the spans i captured in console matched my expectations.