Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to OpenAI Spans and Metrics conventions #1

Merged
merged 3 commits into from
Nov 15, 2023
Merged

Updates to OpenAI Spans and Metrics conventions #1

merged 3 commits into from
Nov 15, 2023

Conversation

drewby
Copy link

@drewby drewby commented Nov 15, 2023

Changes

Here are some proposed changes based on the conversation in your PR. I know we haven't agreed to move LLM history to events, so I'm just suggesting here what it might look like if it were events.

  • Adds OpenAI Metrics from @lmolkova fork.
    • I added llm prefix to her metric names.
  • Updates to OpenAI Spans per our conversation on your PR.
    • I repeated the llm attributes in addition to the openai. This is similar to other conventions where "server.address" gets repeated for clarity.
    • I updated names and added new attributes from the recent API changes (functions are not tools, addition of seed and system_fingerprint, etc
    • Moved Messages, Tools, Choices to Span Events and made them optional with a SHOULD be configured by user of instrumentation libraries.

@cartermp cartermp merged commit b9b4d99 into cartermp:cartermp/ai Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants