Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update staking pool creation #128

Closed
7 tasks
brunomenezes opened this issue Sep 7, 2023 · 0 comments · Fixed by #136
Closed
7 tasks

Update staking pool creation #128

brunomenezes opened this issue Sep 7, 2023 · 0 comments · Fixed by #136
Assignees
Labels
staking Changes targeted to the Staking platform type:refactor A code change that neither fixes a bug nor adds a feature

Comments

@brunomenezes
Copy link
Collaborator

📄 Context

Currently, we offer two commission models when creating a staking pool. that is, Gas-based and Flat-rate commissions. Based on the usage of both models, we will streamline and simplify to only offer the Flat-rate based. We currently have only one pool using Gas-based on mainnet that has no users and is "not active".

✔️ Solution

Remove the Gas-based option in the Commission Model step in the node-runners staking pool creation feature.

📈 Subtasks

  • Remove the Gas-based option.
  • Validations are updated as required.
  • Update tests related to that step.
  • Update stories, if any.

🎯 Definition of Done

  • The staking pool creation flow is functioning as expected.
  • CI checks are passing.
  • Vercel deployments have no problems.
@brunomenezes brunomenezes added type:refactor A code change that neither fixes a bug nor adds a feature staking Changes targeted to the Staking platform labels Sep 7, 2023
@nevendyulgerov nevendyulgerov self-assigned this Sep 11, 2023
@nevendyulgerov nevendyulgerov linked a pull request Sep 13, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
staking Changes targeted to the Staking platform type:refactor A code change that neither fixes a bug nor adds a feature
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants