Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#128 Remove gas based commission #136

Merged
merged 1 commit into from
Sep 19, 2023
Merged

#128 Remove gas based commission #136

merged 1 commit into from
Sep 19, 2023

Conversation

nevendyulgerov
Copy link
Contributor

No description provided.

@nevendyulgerov nevendyulgerov added staking Changes targeted to the Staking platform type:feature new feature or improvement over an existing feature labels Sep 13, 2023
@nevendyulgerov nevendyulgerov self-assigned this Sep 13, 2023
@vercel
Copy link

vercel bot commented Sep 13, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
staking ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 19, 2023 0:58am

@nevendyulgerov nevendyulgerov linked an issue Sep 13, 2023 that may be closed by this pull request
Update staking pool creation #128
Closed
7 tasks
@brunomenezes
Copy link
Collaborator

@nevendyulgerov,
The PR #140 is already merged. Therefore, a rebase should solve the build problem here.

@brunomenezes brunomenezes force-pushed the feature/128-remove-gas-based-commission branch from 8716ade to a59b140 Compare September 19, 2023 00:53
@coveralls
Copy link

Pull Request Test Coverage Report for Build 6229731042

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.2%) to 72.506%
Files with Coverage Reduction New Missed Lines %
apps/staking/src/components/pools/steps/CommissionModel/FlatRateCommission.tsx 2 84.38%
Totals Coverage Status
Change from base Build 6217495063: -0.2%
Covered Lines: 2317
Relevant Lines: 3046
💛 - Coveralls

@brunomenezes brunomenezes merged commit d48a9f9 into main Sep 19, 2023
6 of 7 checks passed
@brunomenezes brunomenezes deleted the feature/128-remove-gas-based-commission branch September 19, 2023 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brunomenezes brunomenezes brunomenezes approved these changes

@dandheedge dandheedge Awaiting requested review from dandheedge

Assignees

@nevendyulgerov nevendyulgerov

Labels
staking Changes targeted to the Staking platform type:feature new feature or improvement over an existing feature
Projects
Explorer Unit
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update staking pool creation
3 participants
@nevendyulgerov @brunomenezes @coveralls