Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove rollups v0.8.2 #23

Closed
7 tasks done
brunomenezes opened this issue Jun 26, 2023 · 0 comments · Fixed by #27
Closed
7 tasks done

Remove rollups v0.8.2 #23

brunomenezes opened this issue Jun 26, 2023 · 0 comments · Fixed by #27
Assignees
Labels
rollups Changes targeted for Rollups Explorer type:refactor A code change that neither fixes a bug nor adds a feature

Comments

@brunomenezes
Copy link
Collaborator

brunomenezes commented Jun 26, 2023

📄 Context

Rollups version v0.8.x helped the development team to build support for the local development of DApps. But since v0.9.0 is the target, we could remove everything related to v0.8.2.

✔️ Solution

Remove the dependency for rollups v0.8.2 and adapt the components that use it that support DApp local development.

  • Remove @cartesi/rollups@0.8.2
  • Change code logic that deals with 0.8.
  • Run a v0.9.0 DApp locally and check that it works as expected.

📈 Subtasks

  • Remove the @cartesi/rollups dependency for v0.8.2
  • Code changes that remove the usage of v0.8.2 related code, e.g. factories for InputFacet and other hooks.
  • Run a DApp 0.9.0 locally and check the integration is working as expected, i.e. I can see my DApp details in the main screen.
  • Test changes (if required, given the above changes)

🎯 Definition of Done

  • Run on DApp local dev mode works as expected when using a DApp locally (i.e. hardhat local blockchain)
  • The web-deployed version that integrates with networks (Goerli, Arbitrum-Goerli) still works as expected.
  • CI checks are passing.
@brunomenezes brunomenezes added type:refactor A code change that neither fixes a bug nor adds a feature rollups Changes targeted for Rollups Explorer labels Jun 26, 2023
@nevendyulgerov nevendyulgerov self-assigned this Jun 27, 2023
@nevendyulgerov nevendyulgerov linked a pull request Jun 30, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rollups Changes targeted for Rollups Explorer type:refactor A code change that neither fixes a bug nor adds a feature
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants