Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#23 Remove rollups v0.8.2 #27

Merged
merged 2 commits into from
Jul 6, 2023
Merged

#23 Remove rollups v0.8.2 #27

merged 2 commits into from
Jul 6, 2023

Conversation

nevendyulgerov
Copy link
Contributor

Removed @cartesi/rollups-0.8 package and related logic for it that resided in:

  • useApplications custom hook and test suite
  • useRollupsFactory
  • inputFacet (removed the module as it was not being used anywhere else)

@nevendyulgerov nevendyulgerov added type:refactor A code change that neither fixes a bug nor adds a feature rollups Changes targeted for Rollups Explorer labels Jun 30, 2023
@nevendyulgerov nevendyulgerov self-assigned this Jun 30, 2023
@vercel
Copy link

vercel bot commented Jun 30, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rollups ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 4, 2023 8:43am
staking ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 4, 2023 8:43am

@nevendyulgerov nevendyulgerov linked an issue Jun 30, 2023 that may be closed by this pull request
Remove rollups v0.8.2 #23
Closed
7 tasks
@github-actions
Copy link

Pull Request Test Coverage Report for Build 5422477200

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.4%) to 73.126%
Totals Coverage Status
Change from base Build 5372965490: 0.4%
Covered Lines: 2544
Relevant Lines: 3315
💛 - Coveralls

@nevendyulgerov nevendyulgerov marked this pull request as ready for review July 3, 2023 15:03
brunomenezes
brunomenezes approved these changes Jul 6, 2023
View reviewed changes
Copy link
Collaborator

@brunomenezes brunomenezes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@brunomenezes brunomenezes merged commit cc75b1f into main Jul 6, 2023
5 checks passed
@brunomenezes brunomenezes deleted the refactor/23-remove-rollups-v082 branch July 6, 2023 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brunomenezes brunomenezes brunomenezes approved these changes

@dandheedge dandheedge Awaiting requested review from dandheedge

Assignees

@nevendyulgerov nevendyulgerov

Labels
rollups Changes targeted for Rollups Explorer type:refactor A code change that neither fixes a bug nor adds a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove rollups v0.8.2
2 participants
@nevendyulgerov @brunomenezes