Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update onboard dependencies and remove duplicates #24

Closed
10 tasks done
brunomenezes opened this issue Jun 26, 2023 · 0 comments · Fixed by #44
Closed
10 tasks done

Update onboard dependencies and remove duplicates #24

brunomenezes opened this issue Jun 26, 2023 · 0 comments · Fixed by #44
Assignees
Labels
package:wallet changes targeting shared wallet package type:chore It is not a new feature or bug fix. e.g. update dependencies, change repository configurations

Comments

@brunomenezes
Copy link
Collaborator

brunomenezes commented Jun 26, 2023

📄 Context

Onboard is the library used to deal with wallet integration. We need to upgrade the core library and all the extra modules. Also, eliminate the duplication of dependency between the package/wallet and apps/staking since we move to a monorepo setup.

Package                        Current Wanted Latest Workspace        Package Type URL
@web3-onboard/coinbase         2.2.0   2.2.0  2.2.4  staking          dependencies https://onboard.blocknative.com
@web3-onboard/coinbase         2.2.0   2.2.0  2.2.4  @explorer/wallet dependencies https://onboard.blocknative.com
@web3-onboard/core             2.11.0  2.11.0 2.20.2 staking          dependencies https://onboard.blocknative.com
@web3-onboard/core             2.11.0  2.11.0 2.20.2 @explorer/wallet dependencies https://onboard.blocknative.com
@web3-onboard/gnosis           2.1.5   2.1.5  2.1.10 staking          dependencies https://onboard.blocknative.com
@web3-onboard/gnosis           2.1.5   2.1.5  2.1.10 @explorer/wallet dependencies https://onboard.blocknative.com
@web3-onboard/injected-wallets 2.4.0   2.4.0  2.10.1 staking          dependencies https://onboard.blocknative.com
@web3-onboard/injected-wallets 2.4.0   2.4.0  2.10.1 @explorer/wallet dependencies https://onboard.blocknative.com
@web3-onboard/ledger           2.3.2   2.3.2  2.4.6  staking          dependencies https://onboard.blocknative.com
@web3-onboard/ledger           2.3.2   2.3.2  2.4.6  @explorer/wallet dependencies https://onboard.blocknative.com
@web3-onboard/react            2.4.1   2.4.1  2.8.7  staking          dependencies https://onboard.blocknative.com
@web3-onboard/react            2.4.1   2.4.1  2.8.7  @explorer/wallet dependencies https://onboard.blocknative.com
@web3-onboard/walletconnect    2.2.1   2.2.1  2.3.9  staking          dependencies https://onboard.blocknative.com
@web3-onboard/walletconnect    2.2.1   2.2.1  2.3.9  @explorer/wallet dependencies https://onboard.blocknative.com

📈 Subtasks

  • Remove the dependency from the staking App.
  • Update the package.json to the new fixed version ( i.e. no ^ or ~ )
  • Create the corresponding issue if an update requires major work.
  • Make sure dependencies are updated in the lock file (yarn.lock).
  • Verify whether the wallet is working as expected. i.e. User could submit the transitions
  • Bump dependencies on the wallet package Bump dependencies for Wallet package #28

🎯 Definition of Done

  • Transaction can be done with success through the web application.
  • Transaction can be done with success through https://app.safe.global.
  • Transaction can be done with success using a hardware wallet (i.e. Ledger)
  • CI verifications are passing.
@brunomenezes brunomenezes added the type:chore It is not a new feature or bug fix. e.g. update dependencies, change repository configurations label Jun 26, 2023
@dandheedge dandheedge self-assigned this Jun 26, 2023
@brunomenezes brunomenezes added the package:wallet changes targeting shared wallet package label Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:wallet changes targeting shared wallet package type:chore It is not a new feature or bug fix. e.g. update dependencies, change repository configurations
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants