#24 Update onboard dependencies and remove duplicates #44

dandheedge · 2023-07-11T06:58:23Z

Update the onboard dependencies on the packages/wallet and remove from apps/staking from the package.json.

vercel · 2023-07-11T06:58:29Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
rollups	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 30, 2023 8:17pm
staking	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 30, 2023 8:17pm

github-actions · 2023-07-11T07:12:53Z

Pull Request Test Coverage Report for Build 5676848998

6 of 6 (100.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.02%) to 73.155%

Totals
Change from base Build 5650857639:	0.02%
Covered Lines:	2567
Relevant Lines:	3344

💛 - Coveralls

dandheedge · 2023-07-14T09:23:49Z

Hi @brunomenezes,

The @web3-onboard/walletconnectpackage is now only support v2 of walletconnect. Where there are some major changes on the setting and UI. The new update that is different from v1 is the projectId that we have to provide it. Right now, I'm using my personal account to get the projectId on WalletConnect and adding it on .env.development and .env.production. Do you think it is the correct solution? Or maybe you can add the new environment on vercel?

Here for further reading on Walletconnect major changes:

packages/wallet/src/useOnboard.tsx

packages/ui/src/styles/onboard.ts

apps/staking/.env.development

apps/staking/.env.production

packages/wallet/src/useOnboard.tsx

brunomenezes · 2023-07-25T04:34:37Z

@dandheedge,
The Vercel build is broken. You probably could replicate that using the build command.

…utils

dandheedge · 2023-07-25T05:30:30Z

@dandheedge, The Vercel build is broken. You probably could replicate that using the build command.

Done

brunomenezes · 2023-07-26T03:00:06Z

@dandheedge,
I am testing the ledger and I will need to push some code.

Upgrade to latest version for core, wallet-connect, ledger and injected-wallets. Configure ledger module to use WC v2.

Centralising env vars required for testing in one environment variables for testing tasks for apps and packages alike.

To highlight what is necessary. Check the README for Environment variables setup.

Update the docker image generation for rollups. Required changes given the upgrade in the wallet-connect version.

Add required configuration for metamask mobile wallet to work with WalletConnect v2.

Add information for next explorer release v3.6.0

brunomenezes

@dandheedge,
Ledger is now working, and we will keep it as an option. Another thing I pushed today was a necessary configuration for Metamask mobile to work with WalletConnect v2. Besides that, I am also already adding a changelog entry for release.

dandheedge marked this pull request as draft July 11, 2023 06:59

dandheedge force-pushed the chore/24-update-onboard-dependencies-and-remove-duplicates branch from e971219 to fbf8148 Compare July 13, 2023 06:22

vercel bot deployed to Preview – staking July 13, 2023 06:27 View deployment

vercel bot deployed to Preview – rollups July 13, 2023 06:33 View deployment

vercel bot deployed to Preview – staking July 14, 2023 09:23 View deployment

vercel bot had a problem deploying to Preview – rollups July 14, 2023 09:28 Failure

dandheedge marked this pull request as ready for review July 17, 2023 05:19

dandheedge requested review from nevendyulgerov and brunomenezes July 17, 2023 05:19

dandheedge force-pushed the chore/24-update-onboard-dependencies-and-remove-duplicates branch from e1ca1f8 to 0d8aba2 Compare July 17, 2023 06:30

vercel bot deployed to Preview – rollups July 17, 2023 06:35 View deployment

vercel bot deployed to Preview – staking July 17, 2023 06:38 View deployment

dandheedge force-pushed the chore/24-update-onboard-dependencies-and-remove-duplicates branch from 0d8aba2 to 65a9da7 Compare July 17, 2023 08:54

vercel bot deployed to Preview – staking July 17, 2023 08:59 View deployment

vercel bot deployed to Preview – rollups July 17, 2023 09:04 View deployment

vercel bot deployed to Preview – rollups July 18, 2023 11:20 View deployment

vercel bot deployed to Preview – staking July 18, 2023 11:22 View deployment

nevendyulgerov reviewed Jul 19, 2023

View reviewed changes

packages/wallet/src/useOnboard.tsx Outdated Show resolved Hide resolved

nevendyulgerov reviewed Jul 19, 2023

View reviewed changes

packages/ui/src/styles/onboard.ts Show resolved Hide resolved

vercel bot deployed to Preview – staking July 21, 2023 04:46 View deployment

vercel bot deployed to Preview – rollups July 21, 2023 04:48 View deployment

nevendyulgerov self-requested a review July 21, 2023 14:30

nevendyulgerov previously approved these changes Jul 21, 2023

View reviewed changes

brunomenezes requested changes Jul 23, 2023

View reviewed changes

apps/staking/.env.development Outdated Show resolved Hide resolved

apps/staking/.env.production Outdated Show resolved Hide resolved

packages/wallet/src/useOnboard.tsx Outdated Show resolved Hide resolved

dandheedge self-assigned this Jul 24, 2023

dandheedge dismissed nevendyulgerov’s stale review via 26e2d48 July 24, 2023 09:21

vercel bot deployed to Preview – rollups July 24, 2023 09:27 View deployment

vercel bot deployed to Preview – rollups July 25, 2023 04:05 View deployment

vercel bot had a problem deploying to Preview – staking July 25, 2023 04:09 Failure

nevendyulgerov and others added 4 commits July 25, 2023 11:37

fix(apps/staking): Transpile web3 libraries

c7d2acc

chore (apps/staking): edit walletconnect project id env on test

59a21ca

chore(apps/staking): move the .env to vercel config. Use the network …

242f837

…utils

chore(apps/staking): bump @types/react package version

3135ee5

dandheedge force-pushed the chore/24-update-onboard-dependencies-and-remove-duplicates branch from f9164fa to 3135ee5 Compare July 25, 2023 05:07

vercel bot deployed to Preview – rollups July 25, 2023 05:13 View deployment

vercel bot deployed to Preview – staking July 25, 2023 05:19 View deployment

vercel bot deployed to Preview – rollups July 26, 2023 05:47 View deployment

brunomenezes added 2 commits July 26, 2023 17:48

chore(packages/wallet): Bump wallet modules version

ae9a9f3

Upgrade to latest version for core, wallet-connect, ledger and injected-wallets. Configure ledger module to use WC v2.

chore(package/ui): update CSS rules for ledger modal

8b00ff6

vercel bot deployed to Preview – staking July 26, 2023 05:53 View deployment

brunomenezes added 3 commits July 27, 2023 16:59

fix(packages/wallet): Add dotenv-cli and test env vars

5e2a339

Centralising env vars required for testing in one environment variables for testing tasks for apps and packages alike.

chore(explorer): Add required env vars with default non-real values

e848b94

To highlight what is necessary. Check the README for Environment variables setup.

feat(docker/rollups): Update docker-bake, Dockerfile and Github action

5ff06c5

Update the docker image generation for rollups. Required changes given the upgrade in the wallet-connect version.

vercel bot deployed to Preview – staking July 27, 2023 05:27 View deployment

vercel bot deployed to Preview – rollups July 27, 2023 05:31 View deployment

feat(apps): Add explore public URL info for metamask mobile wallet

11ddc2b

Add required configuration for metamask mobile wallet to work with WalletConnect v2.

vercel bot deployed to Preview – staking July 30, 2023 18:18 View deployment

vercel bot deployed to Preview – rollups July 30, 2023 18:20 View deployment

doc(explorer): Add changelog entry

9cf2d70

Add information for next explorer release v3.6.0

vercel bot deployed to Preview – rollups July 30, 2023 20:16 View deployment

vercel bot deployed to Preview – staking July 30, 2023 20:17 View deployment

brunomenezes approved these changes Jul 30, 2023

View reviewed changes

brunomenezes merged commit 2e57c57 into main Jul 30, 2023
8 of 9 checks passed

brunomenezes deleted the chore/24-update-onboard-dependencies-and-remove-duplicates branch July 30, 2023 20:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#24 Update onboard dependencies and remove duplicates #44

#24 Update onboard dependencies and remove duplicates #44

dandheedge commented Jul 11, 2023 •

edited

Loading

vercel bot commented Jul 11, 2023 •

edited

Loading

github-actions bot commented Jul 11, 2023 •

edited

Loading

dandheedge commented Jul 14, 2023

brunomenezes commented Jul 25, 2023

dandheedge commented Jul 25, 2023

brunomenezes commented Jul 26, 2023

brunomenezes left a comment

#24 Update onboard dependencies and remove duplicates #44

#24 Update onboard dependencies and remove duplicates #44

Conversation

dandheedge commented Jul 11, 2023 • edited Loading

vercel bot commented Jul 11, 2023 • edited Loading

github-actions bot commented Jul 11, 2023 • edited Loading

Pull Request Test Coverage Report for Build 5676848998

💛 - Coveralls

dandheedge commented Jul 14, 2023

brunomenezes commented Jul 25, 2023

dandheedge commented Jul 25, 2023

brunomenezes commented Jul 26, 2023

brunomenezes left a comment

Choose a reason for hiding this comment

dandheedge commented Jul 11, 2023 •

edited

Loading

vercel bot commented Jul 11, 2023 •

edited

Loading

github-actions bot commented Jul 11, 2023 •

edited

Loading