Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add message when DApp has no inputs #49

Closed
5 tasks done
brunomenezes opened this issue Jul 12, 2023 · 0 comments · Fixed by #61
Closed
5 tasks done

Add message when DApp has no inputs #49

brunomenezes opened this issue Jul 12, 2023 · 0 comments · Fixed by #61
Assignees
Labels
rollups Changes targeted for Rollups Explorer type:feature new feature or improvement over an existing feature

Comments

@brunomenezes
Copy link
Collaborator

brunomenezes commented Jul 12, 2023

📄 Context

The DApps details view currently shows a message for error when there are problems with the guessed URL, or it lists the inputs in case we have data. For the use case where the graphQL connection is established without problems, but there are no Inputs, we display an empty body below the search. It is not bad; however, we can do a bit a better 👍

✔️ Solution

Display a centralised message to provide feedback that all is well, but the DApp has not produced any inputs yet. The key points are;

  • Only display such a message when; no errors happen on the graphQL side, and there are no data back from the fetch.
  • Otherwise, it should not be displayed.

📈 Subtasks

  • Centralise an informative notification below the search area with the following copy Looks like there are no inputs yet...
  • Add new test cases to cover the new code.

🎯 Definition of Done

  • Should display the above copy when the connection is established, but there are no data to display.
  • CI checks and new test cases are passing.
  • Vercel deployment is going through without problems.
@brunomenezes brunomenezes added type:feature new feature or improvement over an existing feature rollups Changes targeted for Rollups Explorer labels Jul 12, 2023
@nevendyulgerov nevendyulgerov self-assigned this Jul 12, 2023
@nevendyulgerov nevendyulgerov linked a pull request Jul 24, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rollups Changes targeted for Rollups Explorer type:feature new feature or improvement over an existing feature
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants