Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#49 Add no inputs label #61

Merged
merged 1 commit into from
Jul 24, 2023
Merged

#49 Add no inputs label #61

merged 1 commit into from
Jul 24, 2023

Conversation

nevendyulgerov
Copy link
Contributor

Added no inputs label.

Before:
Screenshot 2023-07-24 at 14 45 32

After:
Screenshot 2023-07-24 at 14 45 38

@nevendyulgerov nevendyulgerov added rollups Changes targeted for Rollups Explorer type:feature new feature or improvement over an existing feature labels Jul 24, 2023
@nevendyulgerov nevendyulgerov self-assigned this Jul 24, 2023
@vercel
Copy link

vercel bot commented Jul 24, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rollups ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 24, 2023 11:53am
staking ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 24, 2023 11:53am

@nevendyulgerov nevendyulgerov linked an issue Jul 24, 2023 that may be closed by this pull request
Add message when DApp has no inputs #49
Closed
5 tasks
@coveralls
Copy link

Pull Request Test Coverage Report for Build 5644420612

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.09%) to 73.225%
Totals Coverage Status
Change from base Build 5638312828: 0.09%
Covered Lines: 2549
Relevant Lines: 3317
💛 - Coveralls

brunomenezes
brunomenezes approved these changes Jul 24, 2023
View reviewed changes
Copy link
Collaborator

@brunomenezes brunomenezes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The funny bit about the prints is that the cards on the top say 700+ inputs, haha. But I know it is the mock server.

@brunomenezes brunomenezes merged commit 584b65a into main Jul 24, 2023
8 of 9 checks passed
@brunomenezes brunomenezes deleted the feature/49-add-no-inputs-message-for-dapp-details-page branch July 24, 2023 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brunomenezes brunomenezes brunomenezes approved these changes

@dandheedge dandheedge Awaiting requested review from dandheedge

Assignees

@nevendyulgerov nevendyulgerov

Labels
rollups Changes targeted for Rollups Explorer type:feature new feature or improvement over an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add message when DApp has no inputs
3 participants
@nevendyulgerov @coveralls @brunomenezes