Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: table head on staking page #11

Merged
merged 2 commits into from
Jun 19, 2023
Merged

Fix: table head on staking page #11

merged 2 commits into from
Jun 19, 2023

Conversation

dandheedge
Copy link
Contributor

Summary

  1. Fixing the table head UI, so the icon of arrow would be inline.
  2. Bump obsolete dependencies
Screenshot 2023-06-14 at 16 21 03

Testing Instructions

Check UI on desktop

Related Issue(s)

Fixes #10

@vercel
Copy link

vercel bot commented Jun 14, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rollups ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 16, 2023 3:38am
staking ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 16, 2023 3:38am

@dandheedge dandheedge marked this pull request as draft June 15, 2023 05:06
@dandheedge dandheedge force-pushed the bug/10-table-head-staking-page branch from 179f809 to 3526a83 Compare June 15, 2023 06:16
@dandheedge dandheedge self-assigned this Jun 15, 2023
@github-actions
Copy link

Pull Request Test Coverage Report for Build 5275449918

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 71.011%
Totals Coverage Status
Change from base Build 5273607514: 0.0%
Covered Lines: 2536
Relevant Lines: 3404
💛 - Coveralls

@dandheedge dandheedge marked this pull request as ready for review June 15, 2023 07:29
@dandheedge
fix (staking): edit thead element on PoolPerformanceTable
8533736
@dandheedge
chore: bump dependencies version
55a285c 
- @cartesi/util
- babel-loader: 9.1.2
- react-icons: 4.9.0
- react-jazzicon: 1.0.4
- react-tooltip: 5.13.2
@dandheedge dandheedge force-pushed the bug/10-table-head-staking-page branch from 3526a83 to 55a285c Compare June 16, 2023 03:36
brunomenezes
brunomenezes approved these changes Jun 19, 2023
View reviewed changes
Copy link
Collaborator

@brunomenezes brunomenezes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@brunomenezes brunomenezes merged commit 7411da8 into main Jun 19, 2023
4 of 5 checks passed
@brunomenezes brunomenezes deleted the bug/10-table-head-staking-page branch June 19, 2023 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brunomenezes brunomenezes brunomenezes approved these changes

@nevendyulgerov nevendyulgerov Awaiting requested review from nevendyulgerov

Assignees

@dandheedge dandheedge

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Table head on staking page UI
2 participants
@dandheedge @brunomenezes