Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rollups): Add input's payload information (Root Payload) #120

Merged
merged 2 commits into from
Aug 29, 2023

Conversation

brunomenezes
Copy link
Collaborator

Summary

Code changes to display the input's payload. So far, we only displayed the payloads for [Notices, Vouchers, Reports].

Changes:

  • Added extra fields to the InputEdge query.
  • Update types and definitions to display the root payload
  • Removed all the unused types and component definitions related to the old Epoch data structure.
  • Included test case for the <InputContent /> component new behaviour for its internal paging. i.e. Since the input root payload is a single field with a string-like value, the paging is unnecessary.

Include extra fields to the InputEdge query. Removed all unused types and components related to old Epoch data structure.
@vercel
Copy link

vercel bot commented Aug 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rollups ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 29, 2023 2:40am
staking ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 29, 2023 2:40am

@coveralls
Copy link

Pull Request Test Coverage Report for Build 6006600488

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.04%) to 73.099%

Files with Coverage Reduction New Missed Lines %
apps/rollups/src/containers/rollups/DApp.tsx 1 87.1%
Totals Coverage Status
Change from base Build 5995141892: -0.04%
Covered Lines: 2554
Relevant Lines: 3330

💛 - Coveralls

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you renaming this directory to 1.0?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah! For consistency even though the schema did not change between versions. Here dc16d1f are the changes

@brunomenezes brunomenezes merged commit ea66c75 into main Aug 29, 2023
6 of 7 checks passed
@brunomenezes brunomenezes deleted the feat/input-root-payload branch August 29, 2023 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants