Update DApps query filtering #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Including the status to avoid trying to list DApps generated by inputs.
brunomenezes
added
rollups
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
tuler
approved these changes
Jun 15, 2023
Pull Request Test Coverage Report for Build 5273508581
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We change the backend to handle the case of inputs targeting DApps that were not yet "instantiated", more details here. So the changes are to improve the filtering to avoid listing non-existing DApps. Also did a small clean-up of unused properties in the query.