Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#139 Remove rollups app #140

Merged
merged 3 commits into from
Sep 18, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
107 changes: 0 additions & 107 deletions .github/workflows/docker-rollups.yml

This file was deleted.

1 change: 0 additions & 1 deletion .prettierignore

This file was deleted.

14 changes: 2 additions & 12 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,8 @@ You can add, remove and upgrade packages from within your monorepo using your pa

### Apps and Packages

- `rollups`: The new rollups explorer App that is [Next.js](https://nextjs.org/) app
- `staking`: The staking explorer also a [Next.js](https://nextjs.org/) app
- `ui`: House to core react components shared by both [rollups](./apps//rollups/) and [staking](./apps//staking/) applications.
- `ui`: House to core react components for [staking](./apps//staking/) applications.
- `services`: Holds common logic to share between apps e.g ENS service.
- `utils`: Holds utilities used inside the packages and also Apps.
- `wallet`: Holds common implementation of a web3 wallet to be shared between apps.
Expand All @@ -43,20 +42,14 @@ To develop all apps and packages, run the following command:
yarn run dev
```

> Note: When running turborepo tasks like `dev` or `build` it will run rollups and staking in parallel. e.g. when you want only to do `dev` on staking app, you should filter the task
> Note: When running turborepo tasks like `dev` or `build` it will run apps like staking in parallel. e.g. when you want only to do `dev` on staking app, you should filter the task

The filtering should be done by the **name** inside the package.json of the targeted `apps/*`

```
yarn run dev --filter staking
```

or

```
yarn run dev --filter rollups
```

### Test coverage reporting

We are using [Coveralls](https://coveralls.io/) as a reporting tool for our tests' coverage. Each workspace that has tests, generates coverage report for them as well using the `test:ci` npm script. At each build we merge coverage reports for all workspaces, and then send the merged report to Coveralls.
Expand All @@ -80,9 +73,6 @@ The project use **tags** that represent releases, including a branch to signal c
That is as follows:

- Combined tag name `v` + SemVer format **tag** (e.g. v3.4.0) to pinpoint repository state on a given production release.
- A different **tag** format for rollups, i.e. `rollups@0.9.0`, is used to initiate the process of releasing docker images with specific versions that match the versioning other rollups projects are using for unison sake.

> The process initiated for rollups docker image generation is a [GitHub Action](./.github/workflows/docker-rollups.yml)

## Turborepo Useful Links

Expand Down
11 changes: 0 additions & 11 deletions apps/rollups/.env.development

This file was deleted.

10 changes: 0 additions & 10 deletions apps/rollups/.env.production

This file was deleted.

4 changes: 0 additions & 4 deletions apps/rollups/.eslintrc

This file was deleted.

34 changes: 0 additions & 34 deletions apps/rollups/.gitignore

This file was deleted.

2 changes: 0 additions & 2 deletions apps/rollups/.prettierignore

This file was deleted.

39 changes: 0 additions & 39 deletions apps/rollups/README.md

This file was deleted.

71 changes: 0 additions & 71 deletions apps/rollups/__tests__/components/DAppCard.test.tsx

This file was deleted.

60 changes: 0 additions & 60 deletions apps/rollups/__tests__/components/DAppsList.test.tsx

This file was deleted.

Loading