Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(explorer): Add new rebranding colours. #141

Merged
merged 2 commits into from
Sep 20, 2023

Conversation

brunomenezes
Copy link
Collaborator

Summary

These are all the changes made to update the staking application with the new colours.

PS: The branch was rebased with the latest from main and all commits squashed.

Related Issue(s)

closes #52

@brunomenezes brunomenezes linked an issue Sep 19, 2023 that may be closed by this pull request
38 tasks
@brunomenezes brunomenezes removed the request for review from dandheedge September 19, 2023 02:16
@vercel
Copy link

vercel bot commented Sep 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
staking ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 20, 2023 1:44am

@brunomenezes brunomenezes marked this pull request as ready for review September 19, 2023 02:17
tuler
tuler previously approved these changes Sep 19, 2023
@coveralls
Copy link

coveralls commented Sep 19, 2023

Pull Request Test Coverage Report for Build 6242941830

  • 292 of 341 (85.63%) changed or added relevant lines in 89 files are covered.
  • 8 unchanged lines in 6 files lost coverage.
  • Overall coverage increased (+0.3%) to 72.787%

Changes Missing Coverage Covered Lines Changed/Added Lines %
apps/staking/src/components/node/NodeStakingDashboard.tsx 0 1 0.0%
apps/staking/src/components/stake/PoolFilters.tsx 6 7 85.71%
packages/ui/src/components/Layout.tsx 2 3 66.67%
apps/staking/src/components/stake/tables/PoolPerformanceTableRow.tsx 11 13 84.62%
apps/staking/src/components/stake/tables/UserStakingPoolsTableRow.tsx 9 11 81.82%
apps/staking/src/containers/pool-manage/PoolManageContainer.tsx 0 2 0.0%
packages/ui/src/components/Icons.tsx 2 4 50.0%
apps/staking/src/components/BlocksChart.tsx 0 4 0.0%
apps/staking/src/components/node/modals/NodeAllowanceModal.tsx 0 4 0.0%
apps/staking/src/components/node/modals/NodeStakeModal.tsx 0 4 0.0%
Files with Coverage Reduction New Missed Lines %
apps/staking/src/components/node/NodeStakingDashboard.tsx 1 0.0%
apps/staking/src/components/node/steps/SetUpNode.tsx 1 0.0%
apps/staking/src/components/stake/components/StakingInstructions.tsx 1 73.33%
apps/staking/src/components/stake/modals/StakingDepositModal.tsx 1 74.42%
apps/staking/src/containers/pool-manage/PoolManageContainer.tsx 1 0.0%
apps/staking/src/components/users/UserTable.tsx 3 72.73%
Totals Coverage Status
Change from base Build 6229867655: 0.3%
Covered Lines: 2519
Relevant Lines: 3285

💛 - Coveralls

@nevendyulgerov
Copy link
Contributor

nevendyulgerov commented Sep 19, 2023

Hey @brunomenezes , @dandheedge , while reviewing this one, I noticed several minor UI issues:

  1. Load more buttons have uppercase text transform:
    Screenshot 2023-09-19 at 13 50 25

I made them normal case.

  1. Hover on stake info button uses old colors in light mode:
    Screenshot 2023-09-19 at 13 53 24

I changed it to use the new color in light mode.

  1. Commissions page has incorrect background color:
    Screenshot 2023-09-19 at 13 54 28

I changed it to dark.gray.primary.

  1. Footer links use old hover color:
    Screenshot 2023-09-19 at 13 55 25

I changed them to use dark.primary color.

  1. Tooltip "Here you can see your current pool allowance" has same bg color as container:
    Screenshot 2023-09-19 at 13 56 13

I changed them to use black bg and white color.

  1. Pool/node creation pages have bg of teal.light for light mode:
    Screenshot 2023-09-19 at 14 27 52

I don't think we have other pages with this bg color, typically we use either white or gray.80. I went ahead and changed the bg colors for both pages to gray.80

I pushed changes for those directly in this branch. Hope you don't mind.

nevendyulgerov
nevendyulgerov previously approved these changes Sep 19, 2023
Co-authored-by: nevendiulgerov <neven.diulgerov@gmail.com>
Co-authored-by: dandhee.damarrama <dandhee.damarrama@gmail.com>
Add information for next explorer release v3.7.0
@brunomenezes brunomenezes merged commit cb1344c into main Sep 20, 2023
6 of 7 checks passed
@brunomenezes brunomenezes deleted the epic/52-theme-update-new-dark-mode branch September 20, 2023 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Theme update to match the rebranding
4 participants